Fix: Only wire upload mapping task if minifyEnabled #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes #82.
We only wire the upload mapping task if variant buildType has
minifyEnabled to true, which basically hints that proguard
rules will run.
Note that I got rid of
variant.register
since I believe we do not need it as we already wire the task manually. Happy to leave it there if needed.Note that we still create the task eagerly for now, which is to be tackled in another PR.
💡 Motivation and Context
This follows a discussion with @marandaneto about #82
💚 How did you test it?
Published locally and ensured green build in debug variant where minifyEnabled is false.
📝 Checklist
🔮 Next steps