fix: Remove logging that could occur while a thread is suspended #2014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Remove some logging that could happen when threads fail to be suspended or resumed.
💡 Motivation and Context
SENTRY_PROF_LOG_KERN_RETURN
will result in a call to a logger that may perform a heap allocation, which is dangerous for the reasons documented here:sentry-cocoa/Sources/Sentry/SentryBacktrace.cpp
Line 127 in 91cf82a
This is an unlikely scenario - if the thread_suspend call fails and we log an error, the thread is likely not suspended - but the logs are low value enough that it's better not to take the risk.
💚 How did you test it?
This is preventing a hard-to-reproduce scenario so there's no way to easily unit test it, but we check that all existing tests pass.
📝 Checklist
🔮 Next steps