Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Simplify has_UIKit logic in SentrySwizzleWrapper #2925

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

philipphofmann
Copy link
Member

Remove a few #if SENTRY_HAS_UIKIT for SentrySwizzleWrapper.

#skip-changelog

@github-actions
Copy link

github-actions bot commented Apr 21, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.60 ms 1246.46 ms 9.86 ms
Size 20.76 KiB 433.19 KiB 412.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
228a909 1248.92 ms 1267.42 ms 18.50 ms
46f5eb8 1212.27 ms 1231.42 ms 19.15 ms
83d2d84 1211.31 ms 1227.34 ms 16.03 ms
a9103fe 1221.49 ms 1243.33 ms 21.84 ms
10ee2ce 1250.90 ms 1258.57 ms 7.67 ms
455619d 1253.08 ms 1265.06 ms 11.98 ms
d413317 1203.27 ms 1215.02 ms 11.75 ms
ecd9ecd 1215.77 ms 1238.70 ms 22.93 ms
f4e0299 1230.33 ms 1249.68 ms 19.35 ms
67460f4 1244.56 ms 1255.96 ms 11.40 ms

App size

Revision Plain With Sentry Diff
228a909 20.76 KiB 425.71 KiB 404.95 KiB
46f5eb8 20.76 KiB 432.37 KiB 411.61 KiB
83d2d84 20.76 KiB 419.66 KiB 398.90 KiB
a9103fe 20.76 KiB 426.95 KiB 406.19 KiB
10ee2ce 20.76 KiB 427.77 KiB 407.00 KiB
455619d 20.76 KiB 432.87 KiB 412.11 KiB
d413317 20.76 KiB 420.71 KiB 399.95 KiB
ecd9ecd 20.76 KiB 420.23 KiB 399.47 KiB
f4e0299 20.76 KiB 427.54 KiB 406.78 KiB
67460f4 20.76 KiB 426.15 KiB 405.39 KiB

Previous results on branch: ref/ui-kit-logic-swizzle-wrapper

Startup times

Revision Plain With Sentry Diff
a31b440 1214.76 ms 1233.18 ms 18.43 ms

App size

Revision Plain With Sentry Diff
a31b440 20.76 KiB 433.19 KiB 412.43 KiB

@philipphofmann philipphofmann merged commit 0001a09 into main Apr 24, 2023
@philipphofmann philipphofmann deleted the ref/ui-kit-logic-swizzle-wrapper branch April 24, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants