-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the option swizzleClassNameExcludes #3813
Conversation
Add an option to exclude certain classes from swizzling. Fixes GH-3798
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3813 +/- ##
=============================================
+ Coverage 89.588% 90.941% +1.352%
=============================================
Files 560 560
Lines 60819 44167 -16652
Branches 21876 15757 -6119
=============================================
- Hits 54487 40166 -14321
+ Misses 5296 3931 -1365
+ Partials 1036 70 -966
... and 537 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e0f077c | 1224.65 ms | 1243.52 ms | 18.87 ms |
e998fd0 | 1254.41 ms | 1272.78 ms | 18.37 ms |
ecd9ecd | 1214.16 ms | 1232.59 ms | 18.43 ms |
9e6665f | 1237.58 ms | 1253.84 ms | 16.26 ms |
20163bb | 1248.92 ms | 1258.48 ms | 9.56 ms |
645f63f | 1231.33 ms | 1247.51 ms | 16.18 ms |
efb0147 | 1245.26 ms | 1266.94 ms | 21.68 ms |
a6ac3d2 | 1219.00 ms | 1231.32 ms | 12.32 ms |
39b1c35 | 1209.73 ms | 1232.40 ms | 22.67 ms |
11ccc16 | 1203.82 ms | 1237.06 ms | 33.24 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e0f077c | 22.85 KiB | 412.59 KiB | 389.74 KiB |
e998fd0 | 21.58 KiB | 414.59 KiB | 393.01 KiB |
ecd9ecd | 20.76 KiB | 420.23 KiB | 399.47 KiB |
9e6665f | 22.84 KiB | 403.52 KiB | 380.67 KiB |
20163bb | 20.76 KiB | 426.82 KiB | 406.06 KiB |
645f63f | 21.58 KiB | 572.91 KiB | 551.33 KiB |
efb0147 | 22.84 KiB | 403.52 KiB | 380.67 KiB |
a6ac3d2 | 20.76 KiB | 436.65 KiB | 415.89 KiB |
39b1c35 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
11ccc16 | 20.76 KiB | 431.71 KiB | 410.95 KiB |
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I have some suggestions to discuss.
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the updates
Add an option to exclude certain classes from swizzling. Fixes getsentryGH-3798
Add an option to exclude certain classes from swizzling. Fixes getsentryGH-3798
📜 Description
Add an option to exclude certain classes from swizzling.
Docs PR getsentry/sentry-docs#9596.
💡 Motivation and Context
Fixes GH-3798
💚 How did you test it?
Unit tests.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps