Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support orientation change for session replay #4194

Merged
merged 64 commits into from
Aug 5, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Session replay will adapt to screen size changes, that usually happens during orientation change.

💚 How did you test it?

Sample and Unit tests

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Base automatically changed from feat(SR)/replay-for-crashes to main July 29, 2024 07:27
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 94.35028% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.480%. Comparing base (61249fb) to head (748b30b).
Report is 6 commits behind head on main.

Files Patch % Lines
...egrations/SessionReplay/SentryOnDemandReplay.swift 91.250% 7 Missing ⚠️
Sources/Sentry/SentrySessionReplayIntegration.m 89.473% 2 Missing ⚠️
...tegrations/SessionReplay/SentrySessionReplay.swift 92.857% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4194       +/-   ##
=============================================
+ Coverage   91.350%   91.480%   +0.129%     
=============================================
  Files          610       611        +1     
  Lines        48963     49251      +288     
  Branches     17596     17810      +214     
=============================================
+ Hits         44728     45055      +327     
+ Misses        4142      4103       -39     
  Partials        93        93               
Files Coverage Δ
...rations/SessionReplay/SentryReplayVideoMaker.swift 100.000% <ø> (ø)
...ions/SessionReplay/SentryOnDemandReplayTests.swift 98.400% <100.000%> (+0.461%) ⬆️
...onReplay/SentrySessionReplayIntegrationTests.swift 98.445% <100.000%> (+0.619%) ⬆️
...tions/SessionReplay/SentrySessionReplayTests.swift 97.419% <100.000%> (-0.214%) ⬇️
...tegrations/SessionReplay/SentrySessionReplay.swift 91.975% <92.857%> (+1.672%) ⬆️
Sources/Sentry/SentrySessionReplayIntegration.m 85.116% <89.473%> (+1.025%) ⬆️
...egrations/SessionReplay/SentryOnDemandReplay.swift 91.823% <91.250%> (+1.382%) ⬆️

... and 45 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61249fb...748b30b. Read the comment docs.

@brustolin brustolin marked this pull request as ready for review July 29, 2024 11:44
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of questions, almost LGTM.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it makes sense to mention why we don't need to run anything async for resumePreviousSessionReplay as crash events are captured from a background thread, as mentioned here #4194 (comment).

LGTM.

@brustolin brustolin enabled auto-merge (squash) August 5, 2024 12:58
@brustolin brustolin merged commit 817009f into main Aug 5, 2024
64 of 67 checks passed
@brustolin brustolin deleted the feat/support-size-change branch August 5, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants