Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include for missing ucontext64_t type #4244

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

tonyarnold
Copy link
Contributor

@tonyarnold tonyarnold commented Aug 7, 2024

📜 Description

Compiling main under Xcode 16.0 beta 5 produces the following error:

Missing '#include <sys/_types/_ucontext64.h>'; 'ucontext64_t' must be declared before it is used

This PR adds the aforementioned include.

💡 Motivation and Context

It allows users to continue building their apps that use Sentry under Xcode 16.0 beta 5.

💚 How did you test it?

I compiled under Xcode 16.0 beta 5 on an arm64 Mac.

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tonyarnold for the help.
I did reproduce this in here.

We just need a changeling entry, which I will add.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.456%. Comparing base (2911760) to head (be6d7c4).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4244       +/-   ##
=============================================
- Coverage   91.473%   91.456%   -0.018%     
=============================================
  Files          612       612               
  Lines        49341     49358       +17     
  Branches     17843     17860       +17     
=============================================
+ Hits         45134     45141        +7     
- Misses        4115      4123        +8     
- Partials        92        94        +2     
Files Coverage Δ
...yCrash/Recording/Tools/SentryCrashMachineContext.c 68.750% <ø> (ø)

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2911760...be6d7c4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants