-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track thermal state #4305
Track thermal state #4305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the new tests are failing.
@brustolin Seems like the failures are unrelated to my changes: |
Yeah those permission errors happen whenever a PR comes in from a fork, because the fork doesn't have access to the secrets in our CI settings. But there are some related failures, like https://github.com/getsentry/sentry-cocoa/actions/runs/10649320635/job/29561450624?pr=4305#step:11:38 |
Ok i think the test is fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4305 +/- ##
=============================================
+ Coverage 91.671% 91.683% +0.011%
=============================================
Files 617 617
Lines 50213 50237 +24
Branches 18129 18158 +29
=============================================
+ Hits 46031 46059 +28
+ Misses 4089 4084 -5
- Partials 93 94 +1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
cc @brustolin |
Thanks very much @gabriellanata |
📜 Description
Adds tracking of device thermal state
💡 Motivation and Context
Thermal state is an important measurement because it can explain device throttling that commonly cause app hangs.
💚 How did you test it?
Added to existing tests and ran tests locally
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps