Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Session replay for crash not created because of a race condition #4314

Merged
merged 4 commits into from
Sep 13, 2024

Merge branch 'main' into fix/last-session-replay

0e8277d
Select commit
Loading
Failed to load commit list.
Merged

fix: Session replay for crash not created because of a race condition #4314

Merge branch 'main' into fix/last-session-replay
0e8277d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 12, 2024 in 0s

91.622% (-0.028%) compared to e1c3819

View this Pull Request on Codecov

91.622% (-0.028%) compared to e1c3819

Details

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.622%. Comparing base (e1c3819) to head (0e8277d).

Files with missing lines Patch % Lines
Sources/Sentry/SentrySessionReplayIntegration.m 82.352% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4314       +/-   ##
=============================================
- Coverage   91.649%   91.622%   -0.028%     
=============================================
  Files          618       617        -1     
  Lines        50251     50180       -71     
  Branches     18145     18062       -83     
=============================================
- Hits         46055     45976       -79     
- Misses        4103      4112        +9     
+ Partials        93        92        -1     
Files with missing lines Coverage Δ
...onReplay/SentrySessionReplayIntegrationTests.swift 98.623% <100.000%> (+0.025%) ⬆️
Sources/Sentry/SentrySessionReplayIntegration.m 84.937% <82.352%> (-0.461%) ⬇️

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c3819...0e8277d. Read the comment docs.