Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add apiTarget and data fields for GraphQL support #1517

Merged
merged 6 commits into from
Jun 14, 2023

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Jun 14, 2023

📜 Description

Adds two new fields. This is basically a copy of getsentry/sentry-java#2775, but for Dart. I plan to use it for https://pub.dev/packages/sentry_link after this gets merged.

💡 Motivation and Context

Better GraphQL support.

💚 How did you test it?

Tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 82.35% and project coverage change: -0.03 ⚠️

Comparison is base (8ccf782) 90.28% compared to head (c1e831f) 90.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1517      +/-   ##
==========================================
- Coverage   90.28%   90.25%   -0.03%     
==========================================
  Files         181      181              
  Lines        5764     5779      +15     
==========================================
+ Hits         5204     5216      +12     
- Misses        560      563       +3     
Impacted Files Coverage Δ
dart/lib/src/protocol/sentry_response.dart 80.00% <76.92%> (-2.76%) ⬇️
dart/lib/src/protocol/sentry_request.dart 98.30% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@marandaneto
Copy link
Contributor

Thanks @ueman

Lint:

"summary": "### [~] 20/30 points: code has no errors, warnings, lints, or formatting issues\n\n

\n\n/tmp/pana_RRRDNM/lib/src/protocol/sentry_request.dart doesn't match the Dart formatter.\n\n\nTo format your files run: dart format .\n
"

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit b34d20c into getsentry:main Jun 14, 2023
@ueman ueman deleted the feature/add-api-target-and-data branch June 14, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants