Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Android): update getting started and feature pages #10290

Merged
merged 7 commits into from
Jun 11, 2024

Conversation

kahest
Copy link
Member

@kahest kahest commented Jun 5, 2024

DESCRIBE YOUR PR

Updates Android getting started page to use new product selector.

This also includes several smaller improvements to streamline the page and the navigation:

  • move recent feature highlights to features page
  • remove some superfluous/old notes that are not important enough any more to call out on the first landing page
  • move some callouts and new items to next steps section
  • refactor file structure so that there's no platform-includes anymore

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • ideally June 11, latest June 20 :)

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 6:00pm

@kahest kahest changed the title feat(Apple): update getting started and feature pages feat(Android): update getting started and feature pages Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Bundle Report

Changes will increase total bundle size by 14.74kB ⬆️

Bundle name Size Change
sentry-docs-server 7.57MB 14.75kB ⬆️
sentry-docs-client 6.21MB 6 bytes ⬇️
sentry-docs-edge-server 478.9kB 3 bytes ⬇️

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm!

docs/platforms/android/index.mdx Outdated Show resolved Hide resolved
@kahest kahest requested a review from a team June 10, 2024 07:30
# Conflicts:
#	platform-includes/getting-started-primer/android.mdx
Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

docs/platforms/android/features/index.mdx Outdated Show resolved Hide resolved
docs/platforms/android/index.mdx Outdated Show resolved Hide resolved
@kahest kahest merged commit 10826db into master Jun 11, 2024
6 checks passed
@kahest kahest deleted the kahest/new-getting-started-android branch June 11, 2024 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants