Onboarding wizard for errors + replay + performance #6633

bruno-garcia · 2023-04-11T21:53:35Z

No description provided.

vercel · 2023-04-11T21:53:40Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sentry-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 24, 2023 10:04am

src/wizard/javascript/angular/with-error-monitoring-and-performance.md

src/wizard/javascript/angular/with-error-monitoring-and-replay.md

src/wizard/javascript/angular/with-error-monitoring.md

src/wizard/javascript/angularjs/with-error-monitoring.md

src/wizard/javascript/remix/with-error-monitoring-and-performance.md

src/wizard/javascript/remix/with-error-monitoring-and-replay.md

src/wizard/javascript/remix/with-error-monitoring-performance-and-replay.md

bruno-garcia · 2023-04-11T22:00:24Z

src/wizard/javascript/remix/with-error-monitoring.md

+import * as Sentry from "@sentry/remix";
+
+Sentry.init({
+  dsn: "___DSN___",


Prisma here on errors only?

Prisma is only for perf - changed with c5b4fc0

src/wizard/javascript/remix/with-error-monitoring-performance-and-replay.md

…and-replay.md

src/wizard/javascript/svelte/with-error-monitoring-and-performance.md

priscilawebdev · 2023-04-13T12:37:07Z

src/wizard/javascript/angular/with-error-monitoring-and-performance.md

+### ErrorHandler and Tracer
+
+The Sentry Angular SDK exports a function to instantiate `ErrorHandler` provider that will automatically send JavaScript errors captured by the Angular's error handler.
+
+```javascript
+import { APP_INITIALIZER, ErrorHandler, NgModule } from "@angular/core";
+import { Router } from "@angular/router";
+// import * as Sentry from "@sentry/angular" // for Angular 10/11 instead
+import * as Sentry from "@sentry/angular-ivy";
+
+@NgModule({
+  // ...
+  providers: [
+    {
+      provide: ErrorHandler,
+      useValue: Sentry.createErrorHandler({
+        showDialog: true,
+      }),
+    },
+    {
+      provide: Sentry.TraceService,
+      deps: [Router],
+    },
+    {
+      provide: APP_INITIALIZER,
+      useFactory: () => () => {},
+      deps: [Sentry.TraceService],
+      multi: true,
+    },
+  ],
+  // ...
+})
+export class AppModule {}


this seems to be essential for Sentry to capture errors in an angular application. can you confirm? Otherwise, I feel like this could be an optional settings as we are doing for the loader

I just stumbled across this. This is definitely required to set up the SDK properly in Angular apps. Otherwise the routing instrumentation doesn't work (==> no/incorrect pageload navigation transactions) and errors would only be caught by the global handlers.

src/wizard/javascript/angular/with-error-monitoring-and-performance.md

src/wizard/javascript/angular/with-error-monitoring-and-replay.md

src/wizard/javascript/angular/with-error-monitoring-performance-and-replay.md

src/wizard/javascript/angular/with-error-monitoring.md

src/wizard/javascript/angularjs/with-error-monitoring-and-performance.md

src/wizard/javascript/angularjs/with-error-monitoring-and-replay.md

src/wizard/javascript/angularjs/with-error-monitoring-performance-and-replay.md

src/wizard/javascript/backbone/with-error-monitoring-and-performance.md

src/wizard/javascript/backbone/with-error-monitoring-and-replay.md

src/wizard/javascript/svelte/with-error-monitoring-and-replay.md

src/wizard/javascript/svelte/with-error-monitoring-performance-and-replay.md

src/wizard/javascript/vue/with-error-monitoring-and-performance.md

src/wizard/javascript/vue/with-error-monitoring-and-replay.md

src/wizard/javascript/vue/with-error-monitoring-performance-and-replay.md

shanamatthews · 2023-04-19T00:16:12Z

Hey @bruno-garcia - I was going to set this up to preview locally, but there's a build error.
It looks like Gatsby is mad about adding these new js frameworks?

Could you get that fixed up so I can preview & review the wizard changes? LMK if you want me to look at it with you :D

bruno-garcia · 2023-04-19T15:43:23Z

Hey @bruno-garcia - I was going to set this up to preview locally, but there's a build error. It looks like Gatsby is mad about adding these new js frameworks?

Could you get that fixed up so I can preview & review the wizard changes? LMK if you want me to look at it with you :D

I reached out to @matejminar for help here since his team made the changes to support this new format. My PR took the react example and expanded to all JS platforms. Matej said folks. will come give a hand on this PR soon 🙏

priscilawebdev · 2023-04-20T15:26:49Z

src/wizard/javascript/nextjs/with-error-monitoring-and-performance.md

+<button
+  type="button"
+  onClick={() => {
+    throw new Error("Sentry Frontend Error");
+  }}
+>
+  Throw error
+</button>


@Jesse-Box thoughts on this?

priscilawebdev · 2023-04-20T15:40:50Z

src/wizard/javascript/remix/with-error-monitoring-and-performance.md

+You can trigger your first event from your development environment by raising an exception somewhere within your application. An example of this would be rendering a button whose `onClick` handler attempts to invoke a method that does not exist:
+
+```javascript
+<button onClick={() => methodDoesNotExist()}>Break the world</button>


@Jesse-Box another example

priscilawebdev · 2023-04-20T16:17:11Z

src/wizard/javascript/nextjs_wizard.md

@@ -1,9 +0,0 @@
-Configure your app automatically with [Sentry wizard](https://docs.sentry.io/platforms/javascript/guides/nextjs/#configure).
-


@AbhiPrasad this file was causing an issue in the build...I believe we do not need this. can you please confirm?

It is being used here:

sentry-docs/src/wizard/javascript/nextjs.md

Line 6 in b22f4be

wizard_setup: "./nextjs_wizard.md"

We still need it.

this was removed in this PR https://github.com/getsentry/sentry-docs/blob/d9410a9fdbfba72df3ae9e8c3483d23e999a593c/src/wizard/javascript/nextjs/index.md

priscilawebdev · 2023-04-20T16:19:04Z

@shanamatthews build is fixed 😉 I am just waiting for @AbhiPrasad answer to my last comment before merging.

bruno-garcia added 7 commits April 11, 2023 16:56

vue

d5cfce3

svelte

998b098

remix

1c93570

angular

bcc9aff

angularjs (1.x)

5b9d632

fix typo

700409e

nit lines

a73bbf4

bruno-garcia commented Apr 11, 2023

View reviewed changes

vercel bot had a problem deploying to Preview April 11, 2023 22:09 Failure

bruno-garcia added 4 commits April 12, 2023 23:43

gatsby

f7c2bc8

angularjs fixes

a5ad64c

ember

e6afb06

backbone

1b7721a

bruno-garcia marked this pull request as ready for review April 13, 2023 03:53

Update src/wizard/javascript/remix/with-error-monitoring-performance-…

ae563d1

…and-replay.md

vercel bot had a problem deploying to Preview April 13, 2023 04:22 Failure

matejminar reviewed Apr 13, 2023

View reviewed changes

src/wizard/javascript/svelte/with-error-monitoring-and-performance.md Outdated Show resolved Hide resolved

priscilawebdev reviewed Apr 13, 2023

View reviewed changes

Remove tracePropagationTargets since we always have a default value

a75bbc8

AbhiPrasad self-assigned this Apr 14, 2023

AbhiPrasad added 2 commits April 14, 2023 13:35

Update svelte instruction configure hint

bc11960

formatting for snippets

4887323

AbhiPrasad requested a review from a team as a code owner April 14, 2023 11:40

AbhiPrasad added 3 commits April 14, 2023 13:40

Merge branch 'master' into feat/onboarding-wizard-replay-perf-options

0e22b38

Remix: only add prisma snippet if perf

c5b4fc0

remove angular traceservice if not using perf

1ddb16d

vercel bot had a problem deploying to Preview April 14, 2023 12:10 Failure

shanamatthews self-assigned this Apr 18, 2023

matejminar mentioned this pull request Apr 20, 2023

Launch final version getsentry/sentry#46728

Closed

3 tasks

Merge branch 'master' into feat/onboarding-wizard-replay-perf-options

d8124e0

vercel bot had a problem deploying to Preview April 20, 2023 13:32 Failure

fix build

ed530f8

vercel bot deployed to Preview April 20, 2023 15:33 View deployment

apply pretty fixes

a2de507

priscilawebdev reviewed Apr 20, 2023

View reviewed changes

vercel bot deployed to Preview April 20, 2023 15:48 View deployment

cr feedback

d9410a9

priscilawebdev reviewed Apr 20, 2023

View reviewed changes

vercel bot deployed to Preview April 20, 2023 16:27 View deployment

Merge branch 'master' into feat/onboarding-wizard-replay-perf-options

43a03fa

vercel bot deployed to Preview April 24, 2023 10:04 View deployment

priscilawebdev merged commit 1e6068e into master Apr 24, 2023

priscilawebdev deleted the feat/onboarding-wizard-replay-perf-options branch April 24, 2023 11:10

priscilawebdev mentioned this pull request May 8, 2023

[EPIC] Setup Docs Refactor getsentry/sentry#48144

Closed

github-actions bot locked and limited conversation to collaborators May 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Onboarding wizard for errors + replay + performance #6633

Onboarding wizard for errors + replay + performance #6633

bruno-garcia commented Apr 11, 2023 •

edited

Loading

vercel bot commented Apr 11, 2023 •

edited

Loading

bruno-garcia Apr 11, 2023

AbhiPrasad Apr 14, 2023

priscilawebdev Apr 13, 2023

Lms24 Apr 19, 2023

shanamatthews commented Apr 19, 2023

bruno-garcia commented Apr 19, 2023

priscilawebdev Apr 20, 2023

priscilawebdev Apr 20, 2023

priscilawebdev Apr 20, 2023

AbhiPrasad Apr 21, 2023

priscilawebdev Apr 24, 2023

priscilawebdev commented Apr 20, 2023

		@@ -1,9 +0,0 @@
		Configure your app automatically with [Sentry wizard](https://docs.sentry.io/platforms/javascript/guides/nextjs/#configure).

Onboarding wizard for errors + replay + performance #6633

Onboarding wizard for errors + replay + performance #6633

Conversation

bruno-garcia commented Apr 11, 2023 • edited Loading

vercel bot commented Apr 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shanamatthews commented Apr 19, 2023

bruno-garcia commented Apr 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

priscilawebdev commented Apr 20, 2023

bruno-garcia commented Apr 11, 2023 •

edited

Loading

vercel bot commented Apr 11, 2023 •

edited

Loading