iOS native profiling #2930
Merged
iOS native profiling #2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vaind
force-pushed
the
feat/ios-native-profiling
branch
from
8aeb05d
to
3f8f036
Compare
filipnavara
reviewed
Nov 30, 2023
vaind
force-pushed
the
feat/ios-native-profiling
branch
from
8be4a87
to
fb13b03
Compare
filipnavara
reviewed
Dec 4, 2023
Co-authored-by: Filip Navara <filip.navara@gmail.com>
vaind
force-pushed
the
feat/ios-native-profiling
branch
from
47559e9
to
5d12ed0
Compare
vaind
force-pushed
the
feat/ios-native-profiling
branch
from
d8a0526
to
c56da69
Compare
bruno-garcia
approved these changes
Dec 8, 2023
|
|
||
| public ISerializable? Collect(Transaction transaction) | ||
| { | ||
| // TODO change return type of CocoaSDKs CollectProfileBetween to NSMutableDictionary |
There was a problem hiding this comment.
do we need a ticket there not to forget this?
There was a problem hiding this comment.
I've already made the change in sentry-cocoa and it's merged but I've missed last-week's release so I'm keeping as is with hopes this gets resolved before the PR is merged. If not, I'll create an issue
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
vaind
force-pushed
the
feat/ios-native-profiling
branch
from
22f018f
to
0c4ebc3
Compare
vaind
force-pushed
the
feat/ios-native-profiling
branch
from
b1e82a0
to
45617e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses sentry-cocoa profiler to capture native profiles. It works for both NativeAOT and MonoAOT. The same approach has been previously used in the Flutter SDK
NativeAOT: https://sentry-sdks.sentry.io/profiling/profile/sentry-dotnet/d4570e7308f24adfadbf41d56455a361/flamegraph/
MonoAOT: https://sentry-sdks.sentry.io/profiling/profile/sentry-dotnet/232b1e4a2f7f4d0598b8b2cc07dccf9c/flamegraph/
