-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR] Add buffer mode and link replays with events/transactions #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
requested review from
adinauer,
stefanosiano and
markushi
as code owners
March 28, 2024 11:47
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1231ec5 | 411.18 ms | 494.74 ms | 83.56 ms |
5424c0f | 455.18 ms | 589.02 ms | 133.84 ms |
b53cf2b | 395.90 ms | 471.88 ms | 75.98 ms |
b35a95b | 335.13 ms | 432.96 ms | 97.83 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1231ec5 | 1.70 MiB | 2.30 MiB | 615.85 KiB |
5424c0f | 1.70 MiB | 2.30 MiB | 615.63 KiB |
b53cf2b | 1.70 MiB | 2.30 MiB | 615.96 KiB |
b35a95b | 1.70 MiB | 2.30 MiB | 615.63 KiB |
markushi
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, left a few minor comments 🚀
sentry-android-replay/src/main/java/io/sentry/android/replay/ReplayIntegration.kt
Show resolved
Hide resolved
Base automatically changed from
rz/feat/session-replay-options
to
rz/feat/session-replay
April 3, 2024 14:54
brustolin
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Some good ideas to implement in Cocoa!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
buffer
mode to buffer last 30s of replay and send them together with an error/crash eventreplayId
tag💡 Motivation and Context
Part of getsentry/sentry#63255
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps