Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Add buffer mode and link replays with events/transactions #3291

Merged
merged 15 commits into from
Apr 4, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Mar 28, 2024

#skip-changelog

📜 Description

  • Add buffer mode to buffer last 30s of replay and send them together with an error/crash event
  • Link replays with events/transactions via the DSC and the replayId tag

💡 Motivation and Context

Part of getsentry/sentry#63255

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Mar 28, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 390.88 ms 440.35 ms 49.47 ms
Size 1.70 MiB 2.30 MiB 616.01 KiB

Previous results on branch: rz/feat/session-replay-errors

Startup times

Revision Plain With Sentry Diff
1231ec5 411.18 ms 494.74 ms 83.56 ms
5424c0f 455.18 ms 589.02 ms 133.84 ms
b53cf2b 395.90 ms 471.88 ms 75.98 ms
b35a95b 335.13 ms 432.96 ms 97.83 ms

App size

Revision Plain With Sentry Diff
1231ec5 1.70 MiB 2.30 MiB 615.85 KiB
5424c0f 1.70 MiB 2.30 MiB 615.63 KiB
b53cf2b 1.70 MiB 2.30 MiB 615.96 KiB
b35a95b 1.70 MiB 2.30 MiB 615.63 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left a few minor comments 🚀

Base automatically changed from rz/feat/session-replay-options to rz/feat/session-replay April 3, 2024 14:54
Copy link

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Some good ideas to implement in Cocoa!!

@romtsn romtsn merged commit 7079d7a into rz/feat/session-replay Apr 4, 2024
21 checks passed
@romtsn romtsn deleted the rz/feat/session-replay-errors branch April 4, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants