Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Capture breadcrumbs (temporary) #3372

Merged
merged 7 commits into from
Apr 25, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Apr 18, 2024

#skip-changelog

📜 Description

  • Adds RRWebBreadcrumbEvents and transforms our breadcrumbs from the scope to these, filtered by the replay segment timespan
  • There's still some things TBD and TODO so will be addressed in follow-up PRs for sure

image

💡 Motivation and Context

Part of getsentry/sentry#63255

Copy link
Contributor

github-actions bot commented Apr 18, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 397.04 ms 446.85 ms 49.81 ms
Size 1.70 MiB 2.32 MiB 633.30 KiB

Baseline results on branch: rz/feat/session-replay-capture-strategies

Startup times

Revision Plain With Sentry Diff
4483671 441.64 ms 522.45 ms 80.81 ms

App size

Revision Plain With Sentry Diff
4483671 1.70 MiB 2.32 MiB 630.58 KiB

Previous results on branch: rz/feat/session-replay-breadcrumbs

Startup times

Revision Plain With Sentry Diff
40daa25 438.42 ms 513.67 ms 75.25 ms

App size

Revision Plain With Sentry Diff
40daa25 1.70 MiB 2.32 MiB 633.29 KiB

@romtsn romtsn force-pushed the rz/feat/session-replay-breadcrumbs branch from b3b7813 to 4c7d1a0 Compare April 18, 2024 16:29
Base automatically changed from rz/feat/session-replay-capture-strategies to rz/feat/session-replay April 25, 2024 10:04
@romtsn romtsn merged commit db66737 into rz/feat/session-replay Apr 25, 2024
21 checks passed
@romtsn romtsn deleted the rz/feat/session-replay-breadcrumbs branch April 25, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants