-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR] Capture gestures/motion events #3390
Merged
romtsn
merged 12 commits into
rz/feat/session-replay
from
rz/feat/session-replay-touch-events
May 29, 2024
Merged
[SR] Capture gestures/motion events #3390
romtsn
merged 12 commits into
rz/feat/session-replay
from
rz/feat/session-replay-touch-events
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
commented
Apr 25, 2024
sentry-android-replay/src/main/java/io/sentry/android/replay/util/FixedWindowCallback.java
Show resolved
Hide resolved
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c5a385c | 371.06 ms | 433.14 ms | 62.08 ms |
0a9348e | 330.94 ms | 405.53 ms | 74.59 ms |
51792bd | 461.35 ms | 479.57 ms | 18.22 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c5a385c | 1.70 MiB | 2.33 MiB | 638.75 KiB |
0a9348e | 1.70 MiB | 2.32 MiB | 638.56 KiB |
51792bd | 1.70 MiB | 2.33 MiB | 640.05 KiB |
markushi
approved these changes
May 28, 2024
sentry-android-replay/src/main/java/io/sentry/android/replay/WindowRecorder.kt
Outdated
Show resolved
Hide resolved
sentry-android-replay/src/main/java/io/sentry/android/replay/capture/BaseCaptureStrategy.kt
Outdated
Show resolved
Hide resolved
markushi
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
WindowRecorder
MouseInteraction
source with typeTouchStart
/TouchCancel
/TouchEnd
TouchMove
source with a list of positionsHere's an example event but playback not yet working: https://sentry-sdks.sentry.io/replays/d297a781640d4f8f966dd0cba27cf142/?project=5428559&query=&referrer=%2Freplays%2F%3AreplaySlug%2F&statsPeriod=1h&t_main=breadcrumbs&yAxis=count%28%29&t=0
💡 Motivation and Context
Part of getsentry/sentry#70065