Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Don't use word "error" in log message about telemetry #548

Merged

Conversation

mateusz-daniluk-xtb
Copy link
Contributor

Summary

Refactored a log message in the telemetry.ts plugin to improve clarity and reduce false positives when searching for errors in logs.

Files Changed

  • packages/bundler-plugin-core/src/plugins/telemetry.ts

Reason for Changes

The previous log message contained the word "error," which led to confusion when searching for actual errors in the logs using ctrl/cmd + F. The modified message improves the clarity of logs and reduces false positives during searches.

Impact of Changes

  • Improved Log Clarity: The updated log message ensures that searches for "error" in the logs will yield actual error instances rather than telemetry information.
  • Reduced False Positives: Developers and users can more easily identify real errors during troubleshooting and debugging sessions.

Additional Notes

This change aims to enhance developer experience by streamlining the process of locating and addressing genuine errors in the build logs.

Updated the log message in the telemetry plugin to avoid using the word "error," reducing false positives when searching logs. This change improves developer experience during debugging.
@lforst lforst changed the title feat(telemetry): improve log clarity for telemetry data feat(telemetry): Improve log clarity for telemetry data Jun 17, 2024
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change. Thank you!

@lforst lforst changed the title feat(telemetry): Improve log clarity for telemetry data feat(telemetry): Don't use word "error" in log message about telemetry Jun 17, 2024
@lforst lforst changed the title feat(telemetry): Don't use word "error" in log message about telemetry feat: Don't use word "error" in log message about telemetry Jun 17, 2024
@lforst lforst enabled auto-merge (squash) June 17, 2024 10:07
@lforst lforst merged commit 6456536 into getsentry:main Jun 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants