fix: startTrackingLongAnimationFrames entry for loop

getsentry · Jul 26, 2024 · 8b8f94d · 8b8f94d
1 parent 9abdea5
commit 8b8f94d
Showing 1 changed file with 13 additions and 14 deletions.
diff --git a/packages/browser-utils/src/metrics/browserMetrics.ts b/packages/browser-utils/src/metrics/browserMetrics.ts
@@ -134,7 +134,7 @@ export function startTrackingLongAnimationFrames(): void {
     }
     for (const entry of list.getEntries() as PerformanceLongAnimationFrameTiming[]) {
       if (!entry.scripts[0]) {
-        break;
+        continue;
       }
 
       const startTime = msToSec((browserPerformanceTimeOrigin as number) + entry.startTime);
@@ -143,20 +143,19 @@ export function startTrackingLongAnimationFrames(): void {
       const attributes: SpanAttributes = {
         [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
       };
+
       const initialScript = entry.scripts[0];
-      if (initialScript) {
-        const { invoker, invokerType, sourceURL, sourceFunctionName, sourceCharPosition } = initialScript;
-        attributes['browser.script.invoker'] = invoker;
-        attributes['browser.script.invoker_type'] = invokerType;
-        if (sourceURL) {
-          attributes['code.filepath'] = sourceURL;
-        }
-        if (sourceFunctionName) {
-          attributes['code.function'] = sourceFunctionName;
-        }
-        if (sourceCharPosition !== -1) {
-          attributes['browser.script.source_char_position'] = sourceCharPosition;
-        }
+      const { invoker, invokerType, sourceURL, sourceFunctionName, sourceCharPosition } = initialScript;
+      attributes['browser.script.invoker'] = invoker;
+      attributes['browser.script.invoker_type'] = invokerType;
+      if (sourceURL) {
+        attributes['code.filepath'] = sourceURL;
+      }
+      if (sourceFunctionName) {
+        attributes['code.function'] = sourceFunctionName;
+      }
+      if (sourceCharPosition !== -1) {
+        attributes['browser.script.source_char_position'] = sourceCharPosition;
       }
 
       const span = startInactiveSpan({