fix(astro): Correctly extract request data

getsentry · Aug 12, 2024 · a24cebc · a24cebc
1 parent 38d9689
commit a24cebc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/packages/astro/src/server/middleware.ts b/packages/astro/src/server/middleware.ts
@@ -12,7 +12,12 @@ import {
   withIsolationScope,
 } from '@sentry/node';
 import type { Client, Scope, Span, SpanAttributes } from '@sentry/types';
-import { addNonEnumerableProperty, objectify, stripUrlQueryAndFragment } from '@sentry/utils';
+import {
+  addNonEnumerableProperty,
+  objectify,
+  stripUrlQueryAndFragment,
+  winterCGRequestToRequestData,
+} from '@sentry/utils';
 import type { APIContext, MiddlewareResponseHandler } from 'astro';
 
 type MiddlewareOptions = {
@@ -86,11 +91,13 @@ async function instrumentRequest(
 
   const isDynamicPageRequest = checkIsDynamicPageRequest(ctx);
 
+  const request = ctx.request;
+
   const { method, headers } = isDynamicPageRequest
-    ? ctx.request
-    : // headers can only be accessed in dynamic routes. Accessing `ctx.request.headers` in a static route
+    ? request
+    : // headers can only be accessed in dynamic routes. Accessing `request.headers` in a static route
       // will make the server log a warning.
-      { method: ctx.request.method, headers: undefined };
+      { method: request.method, headers: undefined };
 
   return continueTrace(
     {
@@ -101,7 +108,7 @@ async function instrumentRequest(
       getCurrentScope().setSDKProcessingMetadata({
         // We store the request on the current scope, not isolation scope,
         // because we may have multiple requests nested inside each other
-        request: isDynamicPageRequest ? ctx.request : { method, url: ctx.request.url },
+        request: isDynamicPageRequest ? winterCGRequestToRequestData(request) : { method, url: request.url },
       });
 
       if (options.trackClientIp && isDynamicPageRequest) {

diff --git a/packages/astro/test/server/middleware.test.ts b/packages/astro/test/server/middleware.test.ts
@@ -224,9 +224,9 @@ describe('sentryMiddleware', () => {
         request: {
           method: 'GET',
           url: '/users',
-          headers: new Headers({
+          headers: {
             'some-header': 'some-value',
-          }),
+          },
         },
       });
       expect(next).toHaveBeenCalledTimes(1);