-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8 Node OpenTelemetry Instrumentation Blockers #12242
Comments
Here is a patch for If you encounter issues with this patch applied, please open a new issue! |
|
FYI - This is fixed, but for the dependencies in
Not sure where / how / when this would be encountered, if at all, but just thought I would share. Thank you for all the effort in getting the ESM stuff resolved! ❤️ |
Ohh, I should note: Adding a resolution takes care of this:
I should also note that we do not use any of the |
Yeah, I guess this is because A resolution is the best short-term fix for this IMHO! 👍 |
resolves #12242 (although there are still some follow ups) https://github.com/open-telemetry/opentelemetry-js/releases/tag/v1.25.0 I think this lockfile looks correct, but lmk if this feels off. resolves #12011 resolves #12059 resolves #12154 resolves #12237 resolves nodejs/import-in-the-middle#77 cc @mohd-akram
With the release of v8 of the Sentry SDK, the Node SDK now relies on OpenTelemetry. OpenTelemetry instrumentation does have some problems though (particularly with ESM because of import-in-the-middle), so this issue aims at documented these gaps.
import-in-the-middle
These are
import-in-the-middle
bugs, which are encountered by Sentry users who want to use Sentry in their ESM app.import-in-the-middle
PRs to be mergedCallExpression
inExportDefaultDeclaration
node DataDog/import-in-the-middle#86Hook
named export DataDog/import-in-the-middle#88import-in-the-middle
open-telemetry/opentelemetry-js#4745getFullCjsExports
does not resolve re-exports from external dependencies DataDog/import-in-the-middle#951.
import-in-the-middle
does not work with multiple loaders.Reported issue: #12011
Node.js issue: nodejs/node#52987
Fix: nodejs/import-in-the-middle#76
2. relative resolution fails for some modules
import-in-the-middle
expects modules to be relative to the current file, but this doesn't always apply (re-exporting for example). Instead we should just use node'sresolve
Reported issue: #12059
IITM issues: nodejs/import-in-the-middle#59, nodejs/import-in-the-middle#62, nodejs/import-in-the-middle#63
Fix: nodejs/import-in-the-middle#78
3.
import-in-the-middle
breaks with duplicate wildcard exportsReported issue: #12154
IITM issue: nodejs/import-in-the-middle#60
Fix: nodejs/import-in-the-middle#79
4. Does not handle
import *
of current fileReported issue: #12237
IITM issue: nodejs/import-in-the-middle#82
Fix: nodejs/import-in-the-middle#83
5. Does not handle
CallExpression
inExportDefaultDeclaration
nodeIITM issue: nodejs/import-in-the-middle#77
Fix: nodejs/import-in-the-middle#85
6. tsx and
--import
seems to not play nicelyReported issue: #12357
Instrumentation and Span Data Quality
This is being tracked by #12109
Performance Degradation with v8 PR.
Tasks
PostgresIntegration problems
We've gotten two different reports (#11897, https://discord.com/channels/621778831602221064/1242436171737333810) that using the postgres integration with Sentry is causing memory issues.
The text was updated successfully, but these errors were encountered: