TypeError: callback is not a function thrown by Sentry.GCPFunction.wrapCloudEventFunction

[dancallaghan]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/serverless

SDK Version

7.69.0

Framework Version

No response

Link to Sentry event

No response

SDK Setup

Sentry.GCPFunction.init({
  dsn: env.sentry.dsn,
  release: env.sentry.release,
  environment: env.sentry.environment,
  integrations: [
    new Integrations.RewriteFrames({
      root: global.__rootdir__,
    }),
  ],
})

Steps to Reproduce

1. Set up a GCP PubSub Cloud Event function with a handler function that does not have the optional callback argument.

export const rawHandler: CloudEventFunction<PubSubData> = async (
  event
) => {
  try {
    console.log(event.data)
  } catch (e) {
    console.log(e)
  }
}

2. Wrap your handler function in sentry

export const handler = Sentry.GCPFunction.wrapCloudEventFunction(
  rawHandler
)

3. Run your function

Expected Result

No error is thrown

Actual Result

A TypeError: callback is not a function error is thrown after the handler function has finished executing.

This is the offending line of code https://github.com/getsentry/sentry-javascript/blob/master/packages/serverless/src/gcpfunction/cloud_events.ts#L62. It invokes a callback without checking if it exists first.

It looks like this was done for regular events, but not for cloud events.

See the following:

• PR: fix(serverless): Check for existence of callback in GCP event handler before calling #5608
• Issue: TypeError: callback is not a function thrown by Sentry.GCPFunction.wrapEventFunction #5607

[Lms24]

Hi @dancallaghan thanks for reporting and thanks for already debugging the issue!
I agree, we should apply the same fix as for the event function.

Since you already found the responsible line, are you interested in submitting a PR? We'd make sure to mention you as a contributor in the next release. If not, no worries, we'll try to fix it ourselves eventually.

[getsantry]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[AbhiPrasad]

Fix released with https://github.com/getsentry/sentry-javascript/releases/tag/7.112.0 - thank you @tcoyze for contributing!!