feat(remix): Add wrapHandleErrorWithSentry
#10370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/wrapHandleErrorWithSentry
branch
from
9e73ddf
to
8d064ef
Compare
AbhiPrasad
reviewed
Jan 29, 2024
| @@ -105,6 +105,26 @@ export function wrapRemixHandleError(err: unknown, { request }: DataFunctionArgs | |||
| }); | |||
| } | |||
|
|
|||
| // To be deprecated in favor of `sentryHandleError` | |||
| export const wrapRemixHandleError = sentryHandleError; | |||
There was a problem hiding this comment.
Let's add a deprecated js doc to this.
There was a problem hiding this comment.
I also realized if we are deprecating we need to add to MIGRATION.md
onurtemizkan
force-pushed
the
onur/wrapHandleErrorWithSentry
branch
from
2b2377d
to
d1eb044
Compare
AbhiPrasad
reviewed
Feb 6, 2024
onurtemizkan
force-pushed
the
onur/wrapHandleErrorWithSentry
branch
from
c613f9c
to
8687723
Compare
AbhiPrasad
reviewed
Feb 20, 2024
MIGRATION.md
Outdated
| This release deprecates `wrapRemixHandleError` in favor of using `sentryHandleError` from `@sentry/remix`. It can be | ||
| used as below: | ||
|
|
||
| ````typescript |
There was a problem hiding this comment.
Suggested change
| ````typescript | |
| ```typescript |
MIGRATION.md
Outdated
| @@ -324,7 +337,7 @@ typescript: | |||
|
|
|||
| ```ts | |||
| const replay = getClient().getIntegrationByName<Replay>('Replay'); | |||
| ``` | |||
| ```` | |||
There was a problem hiding this comment.
GitHub doesn't allow me to auto suggest this, but this should be ``` instead of ```` (3 instead of 4)
onurtemizkan
force-pushed
the
onur/wrapHandleErrorWithSentry
branch
4 times, most recently
from
022dae4
to
e7149f2
Compare
onurtemizkan
force-pushed
the
onur/wrapHandleErrorWithSentry
branch
from
e7149f2
to
b32c098
Compare
onurtemizkan
force-pushed
the
onur/wrapHandleErrorWithSentry
branch
from
b32c098
to
818d411
Compare
onurtemizkan
force-pushed
the
onur/wrapHandleErrorWithSentry
branch
from
818d411
to
96d0f36
Compare
Bundle ReportChanges will decrease total bundle size by 3.42MB ⬇️
|
onurtemizkan
force-pushed
the
onur/wrapHandleErrorWithSentry
branch
from
96d0f36
to
58cd216
Compare
onurtemizkan
force-pushed
the
onur/wrapHandleErrorWithSentry
branch
from
58cd216
to
96ceab7
Compare
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
onurtemizkan
force-pushed
the
onur/wrapHandleErrorWithSentry
branch
from
96ceab7
to
34f57f5
Compare
AbhiPrasad
approved these changes
Apr 26, 2024
6 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #10212
Sentry.wrapHandleErrorWithSentryfor customhandleErrorimplementations.handleErrorimplementation, then runs the Sentry's capture logic.wrapRemixHandleErrortosentryHandleError, to avoid confusion. We're still exportingwrapRemixHandleErroras alias.