Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aws-serverless): Add comment about dist path import #12383

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Jun 6, 2024

Adding a comment in package.json with "//" is safe, as npm reserved this for comments (see here).

@andreiborza
Copy link
Member

Adding a comment in package.json with "//" is safe, as npm reserved this for comments (see here).

wow TIL

s1gr1d and others added 2 commits June 6, 2024 16:20
Copy link
Contributor

github-actions bot commented Jun 6, 2024

size-limit report 📦

Path Size
@sentry/browser 22 KB (0%)
@sentry/browser (incl. Tracing) 33.05 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.65 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.94 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.7 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.82 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 86.66 KB (0%)
@sentry/browser (incl. metrics) 26.18 KB (0%)
@sentry/browser (incl. Feedback) 38.16 KB (0%)
@sentry/browser (incl. sendFeedback) 26.59 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.14 KB (0%)
@sentry/react 24.77 KB (0%)
@sentry/react (incl. Tracing) 36.07 KB (0%)
@sentry/vue 26 KB (0%)
@sentry/vue (incl. Tracing) 34.87 KB (0%)
@sentry/svelte 22.13 KB (0%)
CDN Bundle 23.35 KB (0%)
CDN Bundle (incl. Tracing) 34.73 KB (0%)
CDN Bundle (incl. Tracing, Replay) 68.67 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 73.82 KB (0%)
CDN Bundle - uncompressed 68.6 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 102.78 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 212.71 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 225.17 KB (0%)
@sentry/nextjs (client) 35.44 KB (0%)
@sentry/sveltekit (client) 33.68 KB (0%)
@sentry/node 115.83 KB (+0.16% 🔺)
@sentry/node - without tracing 94.91 KB (+0.17% 🔺)
@sentry/aws-serverless 104.12 KB (+0.18% 🔺)

@s1gr1d s1gr1d merged commit e84230e into develop Jun 6, 2024
79 checks passed
@s1gr1d s1gr1d deleted the sig/aws-comment branch June 6, 2024 14:48
billyvg pushed a commit that referenced this pull request Jun 10, 2024
Adding a comment in `package.json` with `"//"` is safe, as npm reserved
this for comments ([see
here](https://groups.google.com/g/nodejs/c/NmL7jdeuw0M/m/yTqI05DRQrIJ)).

---------

Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants