-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): Add request
parameter to httpIntegration
ignore callbacks
#12930
Merged
Lms24
merged 1 commit into
develop
from
lms/feat-node-http-add-request-param-to-ignore-callbacks
Jul 16, 2024
Merged
feat(node): Add request
parameter to httpIntegration
ignore callbacks
#12930
Lms24
merged 1 commit into
develop
from
lms/feat-node-http-add-request-param-to-ignore-callbacks
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...kages/node-integration-tests/suites/tracing/httpIntegration/server-ignoreOutgoingRequests.js
Dismissed
Show dismissed
Hide dismissed
4c5288e
to
6d4c859
Compare
Lms24
commented
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this file look more drastic than they are. I just grouped the two tests (1 existed previously, 1 added new) per ignore hook under a describe
block causing the large diff.
size-limit report 📦
|
Base automatically changed from
lms/fix-node-http-ignoreIncomingRequests-url
to
develop
July 16, 2024 11:56
6d4c859
to
67f4e32
Compare
mydea
approved these changes
Jul 16, 2024
AbhiPrasad
approved these changes
Jul 16, 2024
3 tasks
This was referenced Aug 9, 2024
This was referenced Aug 27, 2024
This was referenced Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a second parameter (
request
) to thehttpIntegration
'signoreIncomingRequests
andignoreOutgoingRequests
callbacks. This allows users to not only filter on the URL as previously but on the entire request objects.Docs PR: getsentry/sentry-docs#10735
ref #12913