fix(browser): Fix bug causing unintentional dropping of transactions #12933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To add some context, this happens for me with the replay integration and particularly for the spans for the request to the worker blob, and only in Chrome. |
lforst
force-pushed
the
lforst-prevent-dropping-of-transactions
branch
from
5ef066c
to
e96b4af
Compare
size-limit report 📦
|
andreiborza
reviewed
Jul 17, 2024
| // There is a SO post attempting to explain this, but it leaves one with open questions: https://stackoverflow.com/questions/23191918/peformance-getentries-and-negative-duration-display | ||
| // The way we clamp the value is probably not accurate, since we have observed this happen for things that may take a while to load, like for example the replay worker. | ||
| // TODO: Investigate why this happens and how to properly mitigate. For now, this is a workaround to prevent transactions being dropped due to negative duration spans. | ||
| entry.duration < 0 ? 0 : entry.duration, |
There was a problem hiding this comment.
l: any reason for not using Math.max?
Suggested change
| entry.duration < 0 ? 0 : entry.duration, | |
| Math.max(0, entry.duration), |
There was a problem hiding this comment.
I have a theory that performance is better for the inline if but can change
Lms24
approved these changes
Jul 17, 2024
| const duration = msToSec( | ||
| // Inexplicibly, Chrome sometimes emits a negative duration. We need to work around this. | ||
| // There is a SO post attempting to explain this, but it leaves one with open questions: https://stackoverflow.com/questions/23191918/peformance-getentries-and-negative-duration-display | ||
| // The way we clamp the value is probably not accurate, since we have observed this happen for things that may take a while to load, like for example the replay worker. |
There was a problem hiding this comment.
does the worker take a while to load though? I'd imagine creating the blob should be fairly fast since the code ships with the already loaded JS SDK bundle by default? My guess yesterday was the opposite: that it's too fast and therefore causing weird timing problems 😅
(maybe this is also blob-specific?)
There was a problem hiding this comment.
I think it loaded in something like 4ms when we tested it (which was locally in dev mode). So not too fast. Even if it loaded "too fast" a negative duration doesn't make sense in my eyes 🤔
This was referenced Aug 9, 2024
This was referenced Aug 27, 2024
This was referenced Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw instances of pageload transactions being dropped because they contained spans with negative durations (
timestamp<start_timestamp).After investigating it seems like performance entries by the browser are emitted with a negative duration. We could only observe this happening in Chrome.
The particular environment this could be (flakily) reproduced is on Chrome, for the scaffold Next.js app, with the Sentry SDK and Replay installed. The negative duration span that was recorded was for the replay worker resource.
Other people also seem to be running into this but so far I don't really understand why the duration is negative and how we would mitigate this properly. This PR is more of a hot-fix than anything else.
Attempts to fix: #12914