Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(feedback): add a missing call of Actor.appendToDom method when DOMContentLoaded event is triggered #12973

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix(feedback): add a missing call of Actor.appendToDom method when DOMContentLoaded event is triggered #12973

merged 1 commit into from
Jul 18, 2024

Conversation

jaspreet57
Copy link
Contributor

Fixing a missing paranthesis to call appendToDom on DOMContentLoaded event.

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Fixes #12970

@jaspreet57 jaspreet57 requested a review from a team as a code owner July 18, 2024 08:20
@jaspreet57 jaspreet57 force-pushed the feedback/fix-feedback-integration-init-setup branch from ce5bcc7 to c1d8efe Compare July 18, 2024 08:45
@andreiborza andreiborza self-requested a review July 18, 2024 09:19
andreiborza
andreiborza approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@andreiborza andreiborza merged commit 1619efc into getsentry:develop Jul 18, 2024
111 checks passed
@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Merged
andreiborza added a commit that referenced this pull request Jul 18, 2024
@github-actions @andreiborza
ref: Add external contributor to CHANGELOG.md (#12974)
803220e 
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #12973

---------

Co-authored-by: andreiborza <168741329+andreiborza@users.noreply.github.com>
Co-authored-by: Andrei Borza <andrei.borza@sentry.io>
@angeloreale angeloreale mentioned this pull request Aug 9, 2024
Closed
This was referenced Aug 9, 2024
Open
Open
@q1blue q1blue mentioned this pull request Aug 9, 2024
Open
@OKEAMAH OKEAMAH mentioned this pull request Aug 10, 2024
Merged
@FengShangWuQi FengShangWuQi mentioned this pull request Aug 11, 2024
Closed
@angeloreale angeloreale mentioned this pull request Aug 15, 2024
Merged
@q1blue q1blue mentioned this pull request Aug 16, 2024
Open
@WontonSam WontonSam mentioned this pull request Aug 16, 2024
Open
@wkylin wkylin mentioned this pull request Aug 19, 2024
Closed
This was referenced Aug 22, 2024
Open
Open
@FengShangWuQi FengShangWuQi mentioned this pull request Aug 25, 2024
Closed
@snyk-io snyk-io bot mentioned this pull request Aug 26, 2024
Open
This was referenced Aug 27, 2024
Open
Open
Open
This was referenced Sep 1, 2024
Open
Open
@FengShangWuQi FengShangWuQi mentioned this pull request Sep 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreiborza andreiborza andreiborza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[User Feedback] Feedback button is not attached to DOM, when it is initialized while DOCUMENT is still loading
2 participants
@jaspreet57 @andreiborza