-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(feedback): add a missing call of Actor.appendToDom method when DOMContentLoaded event is triggered #12973
Merged
andreiborza
merged 1 commit into
getsentry:develop
from
jaspreet57:feedback/fix-feedback-integration-init-setup
Jul 18, 2024
Merged
fix(feedback): add a missing call of Actor.appendToDom method when DOMContentLoaded event is triggered #12973
andreiborza
merged 1 commit into
getsentry:develop
from
jaspreet57:feedback/fix-feedback-integration-init-setup
Jul 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MContentLoaded event is triggered
ce5bcc7
to
c1d8efe
Compare
andreiborza
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
andreiborza
added a commit
that referenced
this pull request
Jul 18, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #12973 --------- Co-authored-by: andreiborza <168741329+andreiborza@users.noreply.github.com> Co-authored-by: Andrei Borza <andrei.borza@sentry.io>
This was referenced Aug 9, 2024
This was referenced Aug 27, 2024
This was referenced Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a missing paranthesis to call
appendToDom
onDOMContentLoaded
event.yarn lint
) & (yarn test
).Fixes #12970