Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Upgrade import-in-the-middle to 1.11.0 #13107

Merged
merged 1 commit into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"@sentry/opentelemetry": "8.20.0",
"@sentry/types": "8.20.0",
"@sentry/utils": "8.20.0",
"import-in-the-middle": "^1.10.0"
"import-in-the-middle": "^1.11.0"
},
"devDependencies": {
"@types/node": "^14.18.0"
Expand Down
12 changes: 0 additions & 12 deletions packages/nuxt/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,18 +126,6 @@ other imports:
}
```

If you are getting an `import-in-the-middle` error message, add the package with a minimum version of `1.10.0` as a
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s1gr1d I removed this note because we now pin IITM versions in @sentry/node, so folks should not run into stale versions anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tested this and yes, it works :)

dependency to your `package.json`
([issue reference](https://github.com/getsentry/sentry-javascript-examples/pull/38#issuecomment-2245259327)):

```json
{
"dependencies": {
"import-in-the-middle": "1.10.0"
}
}
```

## Uploading Source Maps

To upload source maps, you can use the `sourceMapsUploadOptions` option inside the `sentry` options of your
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -20493,10 +20493,10 @@ import-in-the-middle@1.7.1:
cjs-module-lexer "^1.2.2"
module-details-from-path "^1.0.3"

import-in-the-middle@^1.10.0, import-in-the-middle@^1.8.1:
version "1.10.0"
resolved "https://registry.yarnpkg.com/import-in-the-middle/-/import-in-the-middle-1.10.0.tgz#f15b0841950ded8d899b635058da5646256949b1"
integrity sha512-Z1jumVdF2GwnnYfM0a/y2ts7mZbwFMgt5rRuVmLgobgahC6iKgN5MBuXjzfTIOUpq5LSU10vJIPpVKe0X89fIw==
import-in-the-middle@^1.11.0, import-in-the-middle@^1.8.1:
version "1.11.0"
resolved "https://registry.yarnpkg.com/import-in-the-middle/-/import-in-the-middle-1.11.0.tgz#a94c4925b8da18256cde3b3b7b38253e6ca5e708"
integrity sha512-5DimNQGoe0pLUHbR9qK84iWaWjjbsxiqXnw6Qz64+azRgleqv9k2kTt5fw7QsOpmaGYtuxxursnPPsnTKEx10Q==
dependencies:
acorn "^8.8.2"
acorn-import-attributes "^1.9.5"
Expand Down
Loading