Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport(tracing): Report dropped spans for transactions #13343

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Aug 13, 2024

mydea and others added 2 commits August 13, 2024 11:20
#13022)

Fixes #12849.

This is a bit tricky because `beforeSendTransaction` can return a
promise, so in order to avoid dealing with this I put the # of spans on
the sdk metadata, and then compare that afterwards.
Copy link
Contributor

github-actions bot commented Aug 13, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.96 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.89 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 76.14 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.52 KB (added)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.77 KB (added)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.66 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.71 KB (added)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.72 KB (added)
@sentry/browser - Webpack (gzipped) 22.91 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 79.17 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.49 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 36.17 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.41 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.92 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 109.52 KB (added)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 76.24 KB (added)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.45 KB (added)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.4 KB (added)
@sentry/react - Webpack (gzipped) 22.94 KB (added)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 90.16 KB (added)
@sentry/nextjs Client - Webpack (gzipped) 54.27 KB (added)
@sentry-internal/feedback - Webpack (gzipped) 17.34 KB (added)

@krystofwoldrich krystofwoldrich merged commit f54c97a into v7 Aug 13, 2024
104 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/backport-dropped-spans branch August 13, 2024 12:06
alexandresoro pushed a commit to alexandresoro/ouca that referenced this pull request Aug 14, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@sentry/node](https://github.com/getsentry/sentry-javascript/tree/master/packages/node) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`7.118.0` -> `7.119.0`](https://renovatebot.com/diffs/npm/@sentry%2fnode/7.118.0/7.119.0) |
| [@sentry/react](https://github.com/getsentry/sentry-javascript/tree/master/packages/react) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.25.0` -> `8.26.0`](https://renovatebot.com/diffs/npm/@sentry%2freact/8.25.0/8.26.0) |

---

### Release Notes

<details>
<summary>getsentry/sentry-javascript (@&#8203;sentry/node)</summary>

### [`v7.119.0`](https://github.com/getsentry/sentry-javascript/releases/tag/7.119.0)

[Compare Source](getsentry/sentry-javascript@7.118.0...7.119.0)

-   backport(tracing): Report dropped spans for transactions ([#&#8203;13343](getsentry/sentry-javascript#13343))

#### Bundle size 📦

| Path                                                                               | Size              |
| ---------------------------------------------------------------------------------- | ----------------- |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay, Feedback) - Webpack (gzipped)              | 80.96 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - Webpack (gzipped)                        | 71.89 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay with Canvas) - Webpack (gzipped)            | 76.14 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) | 65.52 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing) - Webpack (gzipped)                                | 35.77 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. browserTracingIntegration) - Webpack (gzipped)              | 35.66 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Feedback) - Webpack (gzipped)                               | 31.71 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. sendFeedback) - Webpack (gzipped)                           | 31.72 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) - Webpack (gzipped)                                                | 22.91 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped)       | 79.17 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped)                 | 70.49 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing) - ES6 CDN Bundle (gzipped)                         | 36.17 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) - ES6 CDN Bundle (gzipped)                                         | 25.41 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) | 221.92 KB |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed)         | 109.52 KB |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) - ES6 CDN Bundle (minified & uncompressed)                         | 76.24 KB  |
| [@&#8203;sentry/browser](https://github.com/sentry/browser) (incl. Tracing) - ES5 CDN Bundle (gzipped)                         | 39.45 KB  |
| [@&#8203;sentry/react](https://github.com/sentry/react) (incl. Tracing, Replay) - Webpack (gzipped)                          | 72.4 KB   |
| [@&#8203;sentry/react](https://github.com/sentry/react) - Webpack (gzipped)                                                  | 22.94 KB  |
| [@&#8203;sentry/nextjs](https://github.com/sentry/nextjs) Client (incl. Tracing, Replay) - Webpack (gzipped)                  | 90.16 KB  |
| [@&#8203;sentry/nextjs](https://github.com/sentry/nextjs) Client - Webpack (gzipped)                                          | 54.27 KB  |
| [@&#8203;sentry-internal/feedback](https://github.com/sentry-internal/feedback) - Webpack (gzipped)                                      | 17.34 KB  |

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - "after 23:30 every weekday,before 6:00 every weekday,before 7:00 every weekend" in timezone Europe/Paris.

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNy4wIiwidXBkYXRlZEluVmVyIjoiMzguMjguMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/18
Reviewed-by: Alexandre Soro <code@soro.dev>
Co-authored-by: renovate <renovate@git.tristess.app>
Co-committed-by: renovate <renovate@git.tristess.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants