Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Don't fail profiling bindings job on cache miss #13464

Merged
merged 6 commits into from
Aug 27, 2024
Merged

ci: Don't fail profiling bindings job on cache miss #13464

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac5b6bf
ci: Don't fail profiling bindings job on cache miss
lforst Aug 26, 2024
fe06ccf
force to run
lforst Aug 26, 2024
e2442f2
dont restore build cache and dont build entire monorepo
lforst Aug 27, 2024
242cf8a
?
lforst Aug 27, 2024
c78f0f5
help
lforst Aug 27, 2024
b31fd9b
cleanup
lforst Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 12 additions & 25 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,10 +1263,10 @@ jobs:
needs: [job_get_metadata, job_build]
# Compiling bindings can be very slow (especially on windows), so only run precompile
# Skip precompile unless we are on a release branch as precompile slows down CI times.
if: |
(needs.job_get_metadata.outputs.changed_profiling_node == 'true') ||
(needs.job_get_metadata.outputs.is_release == 'true') ||
(github.event_name != 'pull_request')
# if: |
lforst marked this conversation as resolved.
Show resolved Hide resolved
# (needs.job_get_metadata.outputs.changed_profiling_node == 'true') ||
# (needs.job_get_metadata.outputs.is_release == 'true') ||
# (github.event_name != 'pull_request')
runs-on: ${{ matrix.os }}
container: ${{ matrix.container }}
timeout-minutes: 30
Expand Down Expand Up @@ -1416,31 +1416,27 @@ jobs:
with:
ref: ${{ env.HEAD_COMMIT }}

- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}

- name: Restore dependency cache
uses: actions/cache/restore@v4
id: restore-dependencies
with:
path: ${{ env.CACHED_DEPENDENCY_PATHS }}
key: ${{ needs.job_build.outputs.dependency_cache_key }}
enableCrossOsArchive: true
fail-on-cache-miss: true

- name: Restore build cache
uses: actions/cache/restore@v4
id: restore-build
with:
path: ${{ env.CACHED_BUILD_PATHS }}
key: ${{ needs.job_build.outputs.dependency_cache_key }}
enableCrossOsArchive: true
fail-on-cache-miss: true
- name: Install dependencies
if: steps.restore-dependencies.outputs.cache-hit != 'true'
run: yarn install --ignore-engines --frozen-lockfile

- name: Configure safe directory
run: |
git config --global --add safe.directory "*"

- name: Install yarn
run: npm i -g yarn@1.22.19 --force

- name: Increase yarn network timeout on Windows
if: contains(matrix.os, 'windows')
run: yarn config set network-timeout 600000 -g
Expand All @@ -1452,15 +1448,6 @@ jobs:
with:
python-version: '3.8.10'

- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}

- name: Install Dependencies
if: steps.restore-dependencies.outputs.cache-hit != 'true'
run: yarn install --frozen-lockfile --ignore-engines --ignore-scripts

- name: Setup (arm64| ${{ contains(matrix.container, 'alpine') && 'musl' || 'glibc' }})
if: matrix.arch == 'arm64' && !contains(matrix.container, 'alpine') && matrix.target_platform != 'darwin'
run: |
Expand Down
Loading