-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby): Add optional filesToDeleteAfterUpload #13610
base: develop
Are you sure you want to change the base?
feat(gatsby): Add optional filesToDeleteAfterUpload #13610
Conversation
@getsentry/team-web-sdk-frontend what does everything think about exposing the API like this? |
I would align the API with the other SDKs. The other SDKs have it mostly like this: sourceMapsUploadOptions: {
sourcemaps: {
assets: ['foo/*.js'],
ignore: ['bar/*.js'],
filesToDeleteAfterUpload: ['baz/*.js'],
},
}, |
I actually think the way we have structured this is suboptimal. Gave the same feedback here: #13493
All other options should be accessible over an |
I could pass |
I've modified this work by using a boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Related #13582
This work adds the
deleteSourcemapsAfterUpload
option to the Gatsby plugin, allowing it to be passed to the Webpack plugin to set thesourceMapFilesToDeleteAfterUpload
without exposing the API.This simplifies our workflow by eliminating the need to apply a Yarn patch to modify the package whenever we want to use
filesToDeleteAfterUpload
.Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint
) & (yarn test
).