Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Angular plugin + add docs #405

Merged
merged 2 commits into from
Nov 3, 2015
Merged

Improve Angular plugin + add docs #405

merged 2 commits into from
Nov 3, 2015

Conversation

benvinegar
Copy link
Contributor

This patch does the following:

  • Plugin now actually works (had module dependency problem before)
  • Uses Raven.addPlugins (like all other plugins)
  • Adds angular.rst documentation page; adds new page to .json index

@mattrobenolt mattrobenolt added this to the 1.3 milestone Nov 3, 2015
mattrobenolt
mattrobenolt reviewed Nov 3, 2015
View reviewed changes
docs/integrations/angular.rst
@@ -0,0 +1,48 @@
Backbone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Words.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nooo

benvinegar added a commit that referenced this pull request Nov 3, 2015
@benvinegar
Merge pull request #405 from getsentry/angular-fixes
dca67ee 
Improve Angular plugin + add docs
@benvinegar benvinegar merged commit dca67ee into master Nov 3, 2015
@benvinegar benvinegar mentioned this pull request Nov 3, 2015
Closed
@mattrobenolt mattrobenolt deleted the angular-fixes branch November 6, 2015 22:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@benvinegar @dcramer @mattrobenolt