Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad level arg in console plugin, other fixes #474

Merged
merged 1 commit into from
Jan 16, 2016

Conversation

benvinegar
Copy link
Contributor

Started by applying #473 to plugins/console, then wrote some tests and found some other bugs:

  • level (passed to Sentry) was always undefined (closure bug)
  • Was only taking first argument from console methods to build message string (now joins with space character ' ')

benvinegar added a commit that referenced this pull request Jan 16, 2016
Fix bad level arg in console plugin, other fixes
@benvinegar benvinegar merged commit 17c029c into master Jan 16, 2016
@benvinegar benvinegar deleted the fix-console-plugin branch January 21, 2016 00:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant