monkey patch react native default error handling without overwriting it #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benvinegar glad to hear your thought 👍 |
| var defaultHandler = (ErrorUtils.getGlobalHandler && ErrorUtils.getGlobalHandler()) | ||
| || ErrorUtils._globalHandler; | ||
| ErrorUtils.setGlobalHandler(function(...args){ | ||
| defaultHandler(...args); |
There was a problem hiding this comment.
I'd preserve the value of this in case that's a factor later: defaultHandler.apply(this, arguments)
|
One last thing – could you re-write this the avoid using the spread operator (or any ES6+ code). I recognize that this runs fine w/ React Native, but I want to introduce some unit tests for this plugin, and requiring advanced JavaScript features complicates the test build. |
|
@benvinegar updated accordingly 👍 |
benvinegar
added a commit
that referenced
this pull request
Feb 4, 2016
monkey patch react native default error handling without overwriting it
1 task
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'setGlobalHandler' would overwrite the default error handler for React Native. This code keeps the default handler by wrapping it the new handler. More about the global error handler for React Native could be found from this discussion: facebook/react-native#1194