Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration for the console plugin to choose levels. Fixes #391. #514

Merged
merged 2 commits into from
Feb 29, 2016
Merged

Configuration for the console plugin to choose levels. Fixes #391. #514

merged 2 commits into from
Feb 29, 2016

Conversation

nevir
Copy link
Contributor

@nevir nevir commented Feb 24, 2016

For example:

Raven.addPlugin(require('raven-js/plugins/console'), console, {levels: ['error']});

@nevir nevir closed this Feb 24, 2016
@nevir nevir reopened this Feb 24, 2016
@benvinegar
Copy link
Contributor

Would you mind changing the 3rd parameter to be an object, options? (Then extract levels from options.) That would let us have a standard API for plugins (3rd argument is always options).

@nevir
Copy link
Contributor Author

nevir commented Feb 24, 2016

👍 PTAL

benvinegar added a commit that referenced this pull request Feb 29, 2016
@benvinegar
Merge pull request #514 from nevir/console-levels
40762d9 
Configuration for the console plugin to choose levels. Fixes #391.
@benvinegar benvinegar merged commit 40762d9 into getsentry:master Feb 29, 2016
@zuibunan zuibunan mentioned this pull request Nov 19, 2016
Closed
@nh2 nh2 mentioned this pull request Aug 23, 2018
Closed
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nevir @benvinegar