Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent review regarding
strlen()
usage revealed an invalid guard for the user-feedbackcomments
parameter:sentry-native/src/sentry_value.c
Line 1274 in 235f837
A unit test didn't cover this, and my review also failed to see it. So, this is a good trigger for adding corresponding test cases, providing an inline function that guards
strlen()
, and introducing it to the codebase from which future contributors can adapt.