Fixes for legacy Windows versions #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
reviewed
Mar 28, 2020
Mixaill
force-pushed
the
win-system-version-2
branch
2 times, most recently
from
ed918a2
to
db443d1
Compare
Swatinem
approved these changes
Mar 29, 2020
also, change fallback from `WINHTTP_ACCESS_TYPE_NO_PROXY` to `WINHTTP_ACCESS_TYPE_DEFAULT_PROXY`
MSVC does not support /O3 flag
Mixaill
force-pushed
the
win-system-version-2
branch
from
1f11a84
to
d11eb8d
Compare
|
@Swatinem now it pass all the unit tests on Windows XP SP3 |
Swatinem
approved these changes
Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake: fixCMAKE_SYSTEM_VERSIONcomparisoncmake: add support for5.2version (2003 / 2003 R2 / XP 64-bit)cmake: disablecrashpadbuild with XP toolchaincmake: link withpathcch.libonly for Windows 8.0+src/path/windows: include<pathcch.h>only for Windows 8.0+src/transports/winhttp: useWINHTTP_ACCESS_TYPE_AUTOMATIC_PROXYonly for Windows 8.1+src/transports/winhttp: fallback toWINHTTP_ACCESS_TYPE_DEFAULT_PROXYinstead ofWINHTTP_ACCESS_TYPE_NO_PROXYsrc/sync: implementInitOnceExecuteOncefor Windows XPsrc/unwinder/dbghelp: do not useCaptureStackBackTraceon Windows XPreadme: add info aboutCMAKE_SYSTEM_VERSIONinto readme