-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update Crashpad and register WER handler #735
Conversation
Good think our CI caught this:
We should be able to make all this conditional depending on the exact version customers want to target. Either way, I would wait for @supervacuus to be back to help with the correct cmake and ifdefs for conditional compilation here. |
Crashpad added a new WER (Windows Error Reporting) handler which needs to be manually registered first in the Windows Registry, and then with the crashpad client.
c4de3c7
to
878d18e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #735 +/- ##
==========================================
- Coverage 83.09% 83.05% -0.04%
==========================================
Files 53 53
Lines 5017 5017
Branches 1100 1100
==========================================
- Hits 4169 4167 -2
- Misses 737 738 +1
- Partials 111 112 +1 |
...by removing the database directory before each test's first example run. In some test-runs we get false positives, because a left-over envelop from a previous totally unrelated (and probably failed) test is picked up and sent during initialization.
...in the context of fast-fail crashes on Windows.
...make the gitignore rule for build directories wider-scoped.
@@ -6,7 +6,7 @@ | |||
|
|||
|
|||
def enumerate_unittests(): | |||
regexp = re.compile("XX\((.*?)\)") | |||
regexp = re.compile(r"XX\((.*?)\)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see deprecation warnings with every test I run because support for regex strings without the r
prefix is soonish unsupported. It requires python 3.6, though (released almost six years ago). I know we focus on compatibility, but maybe it is less complicated here, since this is only used by devs? Fine to change this in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those are some nice testsuite improvements!
Crashpad added a new WER (Windows Error Reporting) handler which needs
to be manually registered first in the Windows Registry, and then with
the crashpad client.
This depends on getsentry/crashpad#69