chore: Add prettier settings and run prettier on the repo #2950

AbhiPrasad · 2023-03-31T17:43:04Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Run prettier on the repo. Based the config off the JS monorepo.

I did this because I attempted to remove usage of @sentry/tracing from the React Native SDK, since we no longer require it to be used. Kept running into formatting inconsistencies, so opened this PR.

💡 Motivation and Context

Helps with consistency in formatting. We also now run this in CI.

💚 How did you test it?

N/A

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

github-actions · 2023-03-31T18:18:02Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1263.84 ms	1271.76 ms	7.92 ms
Size	2.36 MiB	2.83 MiB	481.13 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	1217.61 ms	1242.66 ms	25.05 ms
`acadc0f`+dirty	1264.38 ms	1290.06 ms	25.68 ms
`70caa60`+dirty	1218.27 ms	1230.30 ms	12.03 ms
`52a8031`+dirty	1280.88 ms	1289.78 ms	8.90 ms
`15c80ab`+dirty	1223.74 ms	1228.96 ms	5.22 ms
`9a3ca65`+dirty	1247.06 ms	1274.58 ms	27.52 ms
`76d1baf`+dirty	1244.10 ms	1268.52 ms	24.42 ms
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`86d6d2c`+dirty	1267.55 ms	1286.21 ms	18.66 ms

App size

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	2.36 MiB	2.82 MiB	462.86 KiB
`acadc0f`+dirty	2.36 MiB	2.83 MiB	480.37 KiB
`70caa60`+dirty	2.36 MiB	2.83 MiB	479.27 KiB
`52a8031`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`15c80ab`+dirty	2.36 MiB	2.83 MiB	474.49 KiB
`9a3ca65`+dirty	2.36 MiB	2.82 MiB	462.89 KiB
`76d1baf`+dirty	2.36 MiB	2.82 MiB	469.45 KiB
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`86d6d2c`+dirty	2.36 MiB	2.82 MiB	462.82 KiB

github-actions · 2023-03-31T18:24:24Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1256.04 ms	1280.02 ms	23.98 ms
Size	2.92 MiB	3.40 MiB	488.05 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	1234.80 ms	1249.20 ms	14.40 ms
`acadc0f`+dirty	1271.12 ms	1272.28 ms	1.16 ms
`70caa60`+dirty	1279.08 ms	1281.54 ms	2.46 ms
`52a8031`+dirty	1255.96 ms	1273.00 ms	17.04 ms
`15c80ab`+dirty	1248.41 ms	1251.24 ms	2.83 ms
`9a3ca65`+dirty	1276.40 ms	1279.14 ms	2.74 ms
`76d1baf`+dirty	1245.00 ms	1257.76 ms	12.76 ms
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms
`e73f4ed`+dirty	1282.90 ms	1309.30 ms	26.40 ms
`86d6d2c`+dirty	1291.62 ms	1296.80 ms	5.18 ms

App size

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	2.92 MiB	3.37 MiB	464.41 KiB
`acadc0f`+dirty	2.92 MiB	3.39 MiB	487.34 KiB
`70caa60`+dirty	2.92 MiB	3.39 MiB	486.04 KiB
`52a8031`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`15c80ab`+dirty	2.92 MiB	3.39 MiB	481.56 KiB
`9a3ca65`+dirty	2.92 MiB	3.37 MiB	464.32 KiB
`76d1baf`+dirty	2.92 MiB	3.38 MiB	475.74 KiB
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB
`e73f4ed`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`86d6d2c`+dirty	2.92 MiB	3.37 MiB	464.31 KiB

github-actions · 2023-03-31T18:40:08Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	279.38 ms	325.26 ms	45.88 ms
Size	7.15 MiB	8.04 MiB	910.85 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	258.75 ms	313.61 ms	54.86 ms
`acadc0f`+dirty	259.04 ms	304.67 ms	45.63 ms
`70caa60`+dirty	308.83 ms	393.06 ms	84.23 ms
`52a8031`+dirty	330.72 ms	358.76 ms	28.03 ms
`15c80ab`+dirty	276.38 ms	327.54 ms	51.17 ms
`9a3ca65`+dirty	344.96 ms	358.92 ms	13.96 ms
`76d1baf`+dirty	339.02 ms	408.65 ms	69.63 ms
`8900e1a`+dirty	371.40 ms	377.70 ms	6.31 ms
`e73f4ed`+dirty	262.98 ms	311.02 ms	48.04 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms

App size

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	7.15 MiB	8.09 MiB	962.72 KiB
`acadc0f`+dirty	7.15 MiB	8.03 MiB	903.20 KiB
`70caa60`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`52a8031`+dirty	7.15 MiB	8.09 MiB	965.95 KiB
`15c80ab`+dirty	7.15 MiB	8.09 MiB	966.13 KiB
`9a3ca65`+dirty	7.15 MiB	8.09 MiB	962.83 KiB
`76d1baf`+dirty	7.15 MiB	8.09 MiB	964.41 KiB
`8900e1a`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`e73f4ed`+dirty	7.15 MiB	8.09 MiB	965.94 KiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB

package.json

krystofwoldrich · 2023-04-03T08:16:19Z

Could you add .prettierignore with

/test/react-native/versions

This path contains downloaded create-react-native apps with different RN versions. Prettier will fail during local runs.

AbhiPrasad · 2023-04-03T08:19:33Z

Done bd54fcd

krystofwoldrich

@AbhiPrasad Thank you. 🙏 It's awesome to have Prettier in RN too. 🚀

github-actions · 2023-04-03T08:51:03Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	327.63 ms	356.82 ms	29.18 ms
Size	17.73 MiB	19.75 MiB	2.02 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	338.94 ms	354.87 ms	15.93 ms
`acadc0f`+dirty	373.24 ms	381.51 ms	8.27 ms
`70caa60`+dirty	299.00 ms	321.02 ms	22.02 ms
`52a8031`+dirty	311.55 ms	321.37 ms	9.82 ms
`15c80ab`+dirty	336.27 ms	350.58 ms	14.31 ms
`9a3ca65`+dirty	326.93 ms	330.14 ms	3.21 ms
`76d1baf`+dirty	335.72 ms	355.52 ms	19.80 ms
`8900e1a`+dirty	430.68 ms	456.13 ms	25.44 ms
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms
`86d6d2c`+dirty	332.90 ms	352.45 ms	19.55 ms

App size

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`acadc0f`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`70caa60`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`52a8031`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`15c80ab`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`9a3ca65`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`76d1baf`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`8900e1a`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`86d6d2c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB

chore: Add prettier settings and run prettier on the repo

8b6ac0c

AbhiPrasad requested review from marandaneto and krystofwoldrich as code owners March 31, 2023 17:43

krystofwoldrich reviewed Apr 3, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

address PR review feedback

bd54fcd

krystofwoldrich approved these changes Apr 3, 2023

View reviewed changes

Merge branch 'main' into abhi-chore-prettier

360201a

krystofwoldrich merged commit d7401ac into main Apr 3, 2023

krystofwoldrich deleted the abhi-chore-prettier branch April 3, 2023 09:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Add prettier settings and run prettier on the repo #2950

chore: Add prettier settings and run prettier on the repo #2950

AbhiPrasad commented Mar 31, 2023 •

edited

Loading

github-actions bot commented Mar 31, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Mar 31, 2023

Baseline results on branch: main

Startup times

App size

github-actions bot commented Mar 31, 2023 •

edited

Loading

Baseline results on branch: main

Startup times

App size

krystofwoldrich commented Apr 3, 2023

AbhiPrasad commented Apr 3, 2023

krystofwoldrich left a comment

github-actions bot commented Apr 3, 2023

Baseline results on branch: main

Startup times

App size

chore: Add prettier settings and run prettier on the repo #2950

chore: Add prettier settings and run prettier on the repo #2950

Conversation

AbhiPrasad commented Mar 31, 2023 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Mar 31, 2023 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Mar 31, 2023

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Mar 31, 2023 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

krystofwoldrich commented Apr 3, 2023

AbhiPrasad commented Apr 3, 2023

krystofwoldrich left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 3, 2023

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

AbhiPrasad commented Mar 31, 2023 •

edited

Loading

github-actions bot commented Mar 31, 2023 •

edited

Loading

github-actions bot commented Mar 31, 2023 •

edited

Loading