Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): Add missing App Start logs when the span is dropped #3861

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement

📜 Description

Adds warning logs when debug: true to places in the SDK code where it's decided that App Start span won't be added.

This will makes it easier for our customer to see why their transactions are missing app start spans as well for us when debugging the SDK.

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 409.11 ms 425.67 ms 16.57 ms
Size 17.73 MiB 19.94 MiB 2.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6e8584e 447.10 ms 474.71 ms 27.61 ms
80b2ce3 385.02 ms 387.36 ms 2.34 ms
728164b 414.34 ms 449.22 ms 34.88 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
457e29f 398.10 ms 421.39 ms 23.29 ms
5bb8d5f 431.21 ms 459.40 ms 28.19 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
31fcca2 391.22 ms 414.78 ms 23.56 ms
e5c9b8b 409.02 ms 426.66 ms 17.64 ms
12427f4 393.69 ms 414.84 ms 21.14 ms

App size

Revision Plain With Sentry Diff
6e8584e 17.73 MiB 19.86 MiB 2.12 MiB
80b2ce3 17.73 MiB 19.75 MiB 2.02 MiB
728164b 17.73 MiB 19.85 MiB 2.12 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
457e29f 17.73 MiB 19.84 MiB 2.10 MiB
5bb8d5f 17.73 MiB 19.93 MiB 2.20 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
31fcca2 17.73 MiB 19.90 MiB 2.17 MiB
e5c9b8b 17.73 MiB 19.83 MiB 2.10 MiB
12427f4 17.73 MiB 19.85 MiB 2.12 MiB

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 383.47 ms 417.19 ms 33.72 ms
Size 7.15 MiB 8.21 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
457e29f+dirty 591.49 ms 612.96 ms 21.47 ms
e5c9b8b+dirty 335.40 ms 360.06 ms 24.67 ms
6e8584e+dirty 383.37 ms 400.84 ms 17.47 ms
62a750b+dirty 370.78 ms 376.73 ms 5.96 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
3ffcddd+dirty 244.82 ms 295.47 ms 50.65 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
5a22220+dirty 384.61 ms 419.06 ms 34.45 ms
b1e8712+dirty 322.55 ms 331.84 ms 9.29 ms

App size

Revision Plain With Sentry Diff
457e29f+dirty 7.15 MiB 8.10 MiB 981.29 KiB
e5c9b8b+dirty 7.15 MiB 8.10 MiB 980.41 KiB
6e8584e+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
62a750b+dirty 7.15 MiB 8.21 MiB 1.06 MiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
3ffcddd+dirty 7.15 MiB 8.04 MiB 912.17 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
5a22220+dirty 7.15 MiB 8.21 MiB 1.06 MiB
b1e8712+dirty 7.15 MiB 8.04 MiB 912.27 KiB

Copy link

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krystofwoldrich krystofwoldrich merged commit aefb75b into main Jun 6, 2024
58 of 60 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/fix-missing-app-start-logs branch June 6, 2024 12:51
@krystofwoldrich krystofwoldrich self-assigned this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants