Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(5) ref(tracing): Remove ReactNativeTracing deprecated options and use new integrations style #3998

Merged
merged 42 commits into from
Aug 13, 2024
Merged

(5) ref(tracing): Remove ReactNativeTracing deprecated options and use new integrations style #3998

merged 42 commits into from
Aug 13, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Refactoring

  • Removed deprecated ReactNativeTracing option idleTimeout use idleTimeoutMs instead

  • Removed deprecated ReactNativeTracing option maxTransactionDuration use finalTimeoutMs instead

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

krystofwoldrich and others added 27 commits June 3, 2024 18:39
@krystofwoldrich
chore(tracing): extract app start to a standalone integration
c3dcfd3
@krystofwoldrich
Merge branch 'v6' into kw/ref-app-start-integration
88d6988
@krystofwoldrich
fix merge
fe53af5
@krystofwoldrich
fix spans, app start is now reported to Sentry
d4ac89f
@krystofwoldrich
fix uikit init and minimal instrumentation edge cases
7c5dcaa
@krystofwoldrich
update js docs
0b42472
@krystofwoldrich
Merge branch 'v6' into kw/ref-app-start-integration
9765eaf
@krystofwoldrich
Add App Start Integration tests
b9e9e9a
@krystofwoldrich
Remove app start test from react native tracing
b334931
@krystofwoldrich
clean up app start tests
4d16787
@krystofwoldrich
fix test affected by the app start extraction
4d84922
@krystofwoldrich
Add standalone app start
0ff2020
@krystofwoldrich
fix
b1eab51
@krystofwoldrich
ref(tracing): Extract NativeFrames as standalone integration
6d1cd70
@krystofwoldrich
Add integration handling test
5eaaad2
@krystofwoldrich
Merge branch 'kw/ref-app-start-integration' into kw/ref-native-frames…
eba6820 
…-integration
@krystofwoldrich
clean up integrations tests
91c1eb8
@krystofwoldrich
move native frames tests
db70c09
@krystofwoldrich
add changelog
e199244
@krystofwoldrich
Merge branch 'kw/ref-app-start-integration' into kw/ref-native-frames…
2956344 
…-integration
@krystofwoldrich
fix
adb53fc
@krystofwoldrich
move the app start test to tracing
699fda7
@krystofwoldrich
Merge branch 'kw/ref-app-start-integration' into kw/ref-native-frames…
7a386ab 
…-integration
@krystofwoldrich
fix tests
ad98ac0
@krystofwoldrich
add changelog
f2b9abe
@krystofwoldrich
ref(tracing): Extract Stall Tracking to a standalone integration
89b2354
@krystofwoldrich
misc(tracing): Remove ReactNativeTracing deprecated options
4f3ca7b
@krystofwoldrich krystofwoldrich changed the title misc(tracing): Remove ReactNativeTracing deprecated options ref(tracing): Remove ReactNativeTracing deprecated options and use new integrations style Aug 7, 2024
@krystofwoldrich krystofwoldrich changed the base branch from kw/ref-stall-tracking-integration to kw/ref-user-interaction-integration August 7, 2024 14:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 450.02 ms 508.92 ms 58.90 ms
Size 17.73 MiB 20.04 MiB 2.31 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.14 ms 1231.57 ms -0.57 ms
Size 2.36 MiB 3.05 MiB 706.21 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1254.16 ms 1244.83 ms -9.33 ms
Size 2.92 MiB 3.62 MiB 719.89 KiB

lucas-zimerman
lucas-zimerman approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question but looks to me, LGTM!

@krystofwoldrich krystofwoldrich marked this pull request as draft August 8, 2024 09:24
@krystofwoldrich krystofwoldrich marked this pull request as ready for review August 8, 2024 09:27
@krystofwoldrich
Copy link
Member Author

krystofwoldrich commented Aug 8, 2024 •
edited
Loading

@lucas-zimerman THank you for the review, could you give it one more look.

I have fixed the comment and also the tests + changelog.

@krystofwoldrich krystofwoldrich changed the title ref(tracing): Remove ReactNativeTracing deprecated options and use new integrations style (5) ref(tracing): Remove ReactNativeTracing deprecated options and use new integrations style Aug 8, 2024
lucas-zimerman
lucas-zimerman approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment to remove some redundant comment, but other than that it looks good to me!

@lucas-zimerman lucas-zimerman mentioned this pull request Aug 9, 2024
Merged
9 tasks
@krystofwoldrich krystofwoldrich mentioned this pull request Aug 12, 2024
Open
Base automatically changed from kw/ref-user-interaction-integration to v6 August 13, 2024 08:26
An error occurred while trying to automatically change base from kw/ref-user-interaction-integration to v6 August 13, 2024 08:26
@krystofwoldrich krystofwoldrich merged commit e52114b into v6 Aug 13, 2024
45 of 47 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/rn-tracing-removed-deprecated-options branch August 13, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @lucas-zimerman