Implement crashedLastRun #4014
Merged
Implement crashedLastRun #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janicduplessis
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
|
@janicduplessis Thank you for the PR, we'll review this shortly. |
janicduplessis
force-pushed
the
@janic/crash-last-run
branch
4 times, most recently
from
43d82b6
to
95cd530
Compare
janicduplessis
force-pushed
the
@janic/crash-last-run
branch
from
95cd530
to
a7b811f
Compare
|
Updated to return null when the sdk does. Also added it to the sample app. |
|
Awesome, thank you, I'll review the changes soon. |
|
I've added simple test for the JS interface, but besides that it looks good. Thank you! |
krystofwoldrich
approved these changes
Aug 26, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This exposes
crashedLastRunfrom the iOS sdk andisCrashedLastRunfrom the android sdk to react native.It is useful to know if the app crashed in the previous launch.
💡 Motivation and Context
Fixes #2797
💚 How did you test it?
Tested in an app on iOS and Android by making it crash then checking that it returns true on next open, or false if didn't crash before.
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps