misc: Move to monorepo structure and Yarn V3 #4057
Conversation
Android (new) Performance metrics 🚀
|
iOS (legacy) Performance metrics 🚀
|
iOS (new) Performance metrics 🚀
|
There was a problem hiding this comment.
Nice work! LGTM from monorepo and publishing perspective. Noted down some things to keep in mind when we add more packages but we can do this whenever it's necessary.
Btw: We added this New SDK (package) Checklist to our monorepo docs to keep in mind what to do in which order. Some things are very JS SDK-specific but the general oder of actions and things to keep in mind should apply to this monorepo as well.
.github/workflows/buildandtest.yml
Outdated
| - name: Pack | ||
| run: yarn pack | ||
| run: | | ||
| cp README.md packages/core |
There was a problem hiding this comment.
l (no action required):
Are you keeping the readme of the SDK top level and you copy it to the package to get it into the tarball? No objections btw, just curious.
In the JS SDK monorepo we keep a Readme per package but I guess that's only gonna become necessary if you have more than one package.
.craft.yml
Outdated
There was a problem hiding this comment.
No immediate action required since you only publish one package at the moment. Once you have more than one pkg, I'd recommend to create one NPM target per package and release in package dependency order.
Android (legacy) Performance metrics 🚀
|
📢 Type of change
📜 Description
This PR change the repository structure to use monorepo setup.
The new structure:
This PR updates the repository to use Yarn V3, as with Yarn V1 the sample applications would not run due to dependencies conflicts. And the original
nohoistwould not fix the issue. WithnmHoistingLimits: workspacesthe RN and Expo application are working correctly.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
@sentry/react-nativedoes introduce unexpected (no) changes compared to version6.0.0-alpha.0#skip-changelog
This is a internal change the SDK package published should be unchanged.