Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sentry Span Origin #4066

Merged
merged 9 commits into from
Sep 11, 2024
Merged

Add Sentry Span Origin #4066

merged 9 commits into from
Sep 11, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • New feature
  • Enhancement

📜 Description

This PR adds sentry span origin to all auto created spans by the RN SDK as well all manual APIs which RN SDK offers to manually create spans.

💡 Motivation and Context

💚 How did you test it?

unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

@krystofwoldrich krystofwoldrich changed the title Kw/add-span-origin Add Sentry Span Origin Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 396.34 ms 436.28 ms 39.94 ms
Size 7.15 MiB 8.34 MiB 1.19 MiB

Previous results on branch: kw/add-span-origin

Startup times

Revision Plain With Sentry Diff
b5caad8+dirty 386.02 ms 467.28 ms 81.26 ms

App size

Revision Plain With Sentry Diff
b5caad8+dirty 7.15 MiB 8.34 MiB 1.19 MiB

Copy link
Contributor

github-actions bot commented Sep 3, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1241.14 ms 1236.82 ms -4.33 ms
Size 2.36 MiB 3.08 MiB 733.14 KiB

Previous results on branch: kw/add-span-origin

Startup times

Revision Plain With Sentry Diff
b5caad8+dirty 1223.76 ms 1225.61 ms 1.86 ms

App size

Revision Plain With Sentry Diff
b5caad8+dirty 2.36 MiB 3.08 MiB 733.04 KiB

Copy link
Contributor

github-actions bot commented Sep 3, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.08 ms 1226.90 ms -6.19 ms
Size 2.92 MiB 3.64 MiB 738.98 KiB

Previous results on branch: kw/add-span-origin

Startup times

Revision Plain With Sentry Diff
b5caad8+dirty 1243.83 ms 1249.53 ms 5.70 ms

App size

Revision Plain With Sentry Diff
b5caad8+dirty 2.92 MiB 3.64 MiB 738.92 KiB

@krystofwoldrich krystofwoldrich requested a review from a team September 4, 2024 11:32
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 695.24 ms 704.53 ms 9.29 ms
Size 17.74 MiB 20.06 MiB 2.33 MiB

Previous results on branch: kw/add-span-origin

Startup times

Revision Plain With Sentry Diff
b5caad8 472.35 ms 478.76 ms 6.41 ms

App size

Revision Plain With Sentry Diff
b5caad8 17.74 MiB 20.06 MiB 2.33 MiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich merged commit f57a28e into v6 Sep 11, 2024
57 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/add-span-origin branch September 11, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants