misc(deprecations): Add Tracing deprecations and replacements #4073

krystofwoldrich · 2024-09-06T17:19:28Z

📢 Type of change

Enhancement

📜 Description

This PR add deprecations and simple replacements which will be dropped in V6.

💚 How did you test it?

sample app, unit tests

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

github-actions · 2024-09-06T17:37:56Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	507.13 ms	518.57 ms	11.44 ms
Size	17.73 MiB	20.06 MiB	2.33 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`52a8031`+dirty	311.55 ms	321.37 ms	9.82 ms
`86d6d2c`+dirty	332.90 ms	352.45 ms	19.55 ms
`0677344`	327.74 ms	337.14 ms	9.40 ms
`80b2ce3`	385.02 ms	387.36 ms	2.34 ms
`dadc233`+dirty	333.78 ms	343.94 ms	10.16 ms
`d197b5c`+dirty	338.94 ms	354.87 ms	15.93 ms
`15c80ab`+dirty	336.27 ms	350.58 ms	14.31 ms
`baa882f`	354.93 ms	356.18 ms	1.25 ms
`9433f35`	347.64 ms	356.22 ms	8.58 ms
`5bb8d5f`	431.21 ms	459.40 ms	28.19 ms

App size

Revision	Plain	With Sentry	Diff
`52a8031`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`86d6d2c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`0677344`	17.73 MiB	19.81 MiB	2.07 MiB
`80b2ce3`	17.73 MiB	19.75 MiB	2.02 MiB
`dadc233`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`d197b5c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`15c80ab`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`baa882f`	17.73 MiB	20.06 MiB	2.33 MiB
`9433f35`	17.73 MiB	19.81 MiB	2.08 MiB
`5bb8d5f`	17.73 MiB	19.93 MiB	2.20 MiB

Previous results on branch: kw/add-tracing-deprecations

Startup times

Revision	Plain	With Sentry	Diff
`f3915e3`	445.89 ms	448.90 ms	3.01 ms

App size

Revision	Plain	With Sentry	Diff
`f3915e3`	17.73 MiB	20.06 MiB	2.33 MiB

github-actions · 2024-09-06T17:54:49Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	435.98 ms	494.06 ms	58.08 ms
Size	7.15 MiB	8.34 MiB	1.19 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`52a8031`+dirty	330.72 ms	358.76 ms	28.03 ms
`86d6d2c`+dirty	267.21 ms	325.24 ms	58.04 ms
`2534337`+dirty	597.14 ms	665.04 ms	67.90 ms
`22e31b6`+dirty	295.75 ms	346.73 ms	50.98 ms
`dadc233`+dirty	363.19 ms	370.37 ms	7.18 ms
`148f924`+dirty	347.36 ms	389.13 ms	41.77 ms
`c398f67`+dirty	315.08 ms	345.60 ms	30.52 ms
`5bb8d5f`+dirty	356.71 ms	389.65 ms	32.94 ms
`d197b5c`+dirty	258.75 ms	313.61 ms	54.86 ms
`15c80ab`+dirty	276.38 ms	327.54 ms	51.17 ms

App size

Revision	Plain	With Sentry	Diff
`52a8031`+dirty	7.15 MiB	8.09 MiB	965.95 KiB
`86d6d2c`+dirty	7.15 MiB	8.09 MiB	962.69 KiB
`2534337`+dirty	7.15 MiB	8.11 MiB	988.68 KiB
`22e31b6`+dirty	7.15 MiB	8.10 MiB	981.29 KiB
`dadc233`+dirty	7.15 MiB	8.04 MiB	910.84 KiB
`148f924`+dirty	7.15 MiB	8.21 MiB	1.07 MiB
`c398f67`+dirty	7.15 MiB	8.21 MiB	1.07 MiB
`5bb8d5f`+dirty	7.15 MiB	8.21 MiB	1.06 MiB
`d197b5c`+dirty	7.15 MiB	8.09 MiB	962.72 KiB
`15c80ab`+dirty	7.15 MiB	8.09 MiB	966.13 KiB

Previous results on branch: kw/add-tracing-deprecations

Startup times

Revision	Plain	With Sentry	Diff
`f3915e3`+dirty	368.26 ms	438.57 ms	70.30 ms

App size

Revision	Plain	With Sentry	Diff
`f3915e3`+dirty	7.15 MiB	8.34 MiB	1.19 MiB

github-actions · 2024-09-06T17:57:34Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1226.81 ms	1233.94 ms	7.13 ms
Size	2.36 MiB	3.08 MiB	734.35 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`dadc233`+dirty	1223.20 ms	1236.88 ms	13.68 ms
`5571a20`+dirty	1203.57 ms	1204.57 ms	1.00 ms
`70e6261`+dirty	1220.09 ms	1230.04 ms	9.95 ms
`62a750b`+dirty	1216.60 ms	1229.14 ms	12.54 ms
`acadc0f`+dirty	1264.38 ms	1290.06 ms	25.68 ms
`6e8584e`+dirty	1274.50 ms	1296.82 ms	22.32 ms
`c398f67`+dirty	1219.67 ms	1225.66 ms	5.99 ms
`86d6d2c`+dirty	1267.55 ms	1286.21 ms	18.66 ms
`e5c9b8b`+dirty	1258.57 ms	1267.32 ms	8.75 ms
`31fcca2`+dirty	1209.17 ms	1216.21 ms	7.04 ms

App size

Revision	Plain	With Sentry	Diff
`dadc233`+dirty	2.36 MiB	2.84 MiB	486.85 KiB
`5571a20`+dirty	2.36 MiB	2.92 MiB	569.93 KiB
`70e6261`+dirty	2.36 MiB	3.03 MiB	680.42 KiB
`62a750b`+dirty	2.36 MiB	2.92 MiB	570.00 KiB
`acadc0f`+dirty	2.36 MiB	2.83 MiB	480.37 KiB
`6e8584e`+dirty	2.36 MiB	2.88 MiB	533.17 KiB
`c398f67`+dirty	2.36 MiB	3.04 MiB	696.27 KiB
`86d6d2c`+dirty	2.36 MiB	2.82 MiB	462.82 KiB
`e5c9b8b`+dirty	2.36 MiB	2.87 MiB	520.43 KiB
`31fcca2`+dirty	2.36 MiB	2.90 MiB	552.95 KiB

Previous results on branch: kw/add-tracing-deprecations

Startup times

Revision	Plain	With Sentry	Diff
`f3915e3`+dirty	1218.31 ms	1220.12 ms	1.81 ms

App size

Revision	Plain	With Sentry	Diff
`f3915e3`+dirty	2.36 MiB	3.08 MiB	734.27 KiB

github-actions · 2024-09-06T18:01:21Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1247.59 ms	1241.71 ms	-5.88 ms
Size	2.92 MiB	3.64 MiB	740.29 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`0677344`+dirty	1252.52 ms	1254.08 ms	1.56 ms
`0ebca77`+dirty	1209.30 ms	1220.33 ms	11.03 ms
`70caa60`+dirty	1279.08 ms	1281.54 ms	2.46 ms
`1d86dd6`+dirty	1289.25 ms	1293.36 ms	4.11 ms
`c2a4e9b`+dirty	1247.39 ms	1243.04 ms	-4.35 ms
`ad6c299`+dirty	1248.50 ms	1248.88 ms	0.38 ms
`34aba08`+dirty	1268.58 ms	1276.80 ms	8.22 ms
`abb7058`+dirty	1260.28 ms	1266.56 ms	6.28 ms
`80b2ce3`+dirty	1245.12 ms	1262.04 ms	16.92 ms
`15c80ab`+dirty	1248.41 ms	1251.24 ms	2.83 ms

App size

Revision	Plain	With Sentry	Diff
`0677344`+dirty	2.92 MiB	3.41 MiB	500.94 KiB
`0ebca77`+dirty	2.92 MiB	3.61 MiB	705.12 KiB
`70caa60`+dirty	2.92 MiB	3.39 MiB	486.04 KiB
`1d86dd6`+dirty	2.92 MiB	3.44 MiB	538.27 KiB
`c2a4e9b`+dirty	2.92 MiB	3.64 MiB	739.91 KiB
`ad6c299`+dirty	2.92 MiB	3.40 MiB	494.12 KiB
`34aba08`+dirty	2.92 MiB	3.41 MiB	499.03 KiB
`abb7058`+dirty	2.92 MiB	3.43 MiB	524.53 KiB
`80b2ce3`+dirty	2.92 MiB	3.40 MiB	492.75 KiB
`15c80ab`+dirty	2.92 MiB	3.39 MiB	481.56 KiB

Previous results on branch: kw/add-tracing-deprecations

Startup times

Revision	Plain	With Sentry	Diff
`f3915e3`+dirty	1248.59 ms	1242.83 ms	-5.76 ms

App size

Revision	Plain	With Sentry	Diff
`f3915e3`+dirty	2.92 MiB	3.64 MiB	740.30 KiB

CHANGELOG.md

samples/react-native/src/App.tsx

src/js/options.ts

test/client.test.ts

lucas-zimerman

Left some non-blocking suggestions and some questions, but nothing blocking the PR.
LGTM!

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

misc(deprecations): Add Tracing deprecations and replacements

fd826e4

krystofwoldrich requested a review from lucas-zimerman as a code owner September 6, 2024 17:19

Fix hermes profiling option

5029651

krystofwoldrich and others added 2 commits September 10, 2024 14:13

Add new options tests

89dbb1d

Update CHANGELOG.md

85aee51

lucas-zimerman reviewed Sep 10, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

lucas-zimerman reviewed Sep 10, 2024

View reviewed changes

samples/react-native/src/App.tsx Show resolved Hide resolved

lucas-zimerman reviewed Sep 10, 2024

View reviewed changes

src/js/options.ts Show resolved Hide resolved

lucas-zimerman reviewed Sep 10, 2024

View reviewed changes

test/client.test.ts Show resolved Hide resolved

lucas-zimerman approved these changes Sep 10, 2024

View reviewed changes

krystofwoldrich and others added 2 commits September 11, 2024 14:00

Apply suggestions from code review

bc64da9

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>

Merge branch 'main' into kw/add-tracing-deprecations

8675509

krystofwoldrich enabled auto-merge (squash) September 11, 2024 12:01

krystofwoldrich merged commit d43a46b into main Sep 11, 2024
55 checks passed

krystofwoldrich deleted the kw/add-tracing-deprecations branch September 11, 2024 12:03

antonis mentioned this pull request Sep 19, 2024

chore(deps): Hotfix: update Cocoa SDK from 8.29.1 to 8.36.0 #4102

Merged

rwachtler mentioned this pull request Sep 21, 2024

[ReactNavigationInstrumentation] Will not send transactiondue to beforeNavigate on react navigation v5 #4109

Open

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

misc(deprecations): Add Tracing deprecations and replacements #4073

misc(deprecations): Add Tracing deprecations and replacements #4073

krystofwoldrich commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw/add-tracing-deprecations

Startup times

App size

github-actions bot commented Sep 6, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw/add-tracing-deprecations

Startup times

App size

github-actions bot commented Sep 6, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw/add-tracing-deprecations

Startup times

App size

github-actions bot commented Sep 6, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw/add-tracing-deprecations

Startup times

App size

lucas-zimerman left a comment

misc(deprecations): Add Tracing deprecations and replacements #4073

misc(deprecations): Add Tracing deprecations and replacements #4073

Conversation

krystofwoldrich commented Sep 6, 2024 • edited Loading

📢 Type of change

📜 Description

💚 How did you test it?

📝 Checklist

github-actions bot commented Sep 6, 2024 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw/add-tracing-deprecations

Startup times

App size

github-actions bot commented Sep 6, 2024 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw/add-tracing-deprecations

Startup times

App size

github-actions bot commented Sep 6, 2024 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw/add-tracing-deprecations

Startup times

App size

github-actions bot commented Sep 6, 2024 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw/add-tracing-deprecations

Startup times

App size

lucas-zimerman left a comment

Choose a reason for hiding this comment

krystofwoldrich commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading

github-actions bot commented Sep 6, 2024 •

edited

Loading