Do not re-raise if Vernier crashes

getsentry · Aug 31, 2024 · 2260888 · 2260888
1 parent c79956a
commit 2260888
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/sentry-ruby/lib/sentry/vernier/profiler.rb b/sentry-ruby/lib/sentry/vernier/profiler.rb
@@ -58,7 +58,7 @@ def set_initial_sample_decision(transaction_sampled)
 
       def start
         return unless @sampled
-        return if !@started
+        return if @started
 
         ::Vernier.start_profile
         @started = true
@@ -72,7 +72,6 @@ def start
           log("Not started since running elsewhere")
         else
           log("Failed to start: #{e.message}")
-          raise e
         end
       end
 

diff --git a/sentry-ruby/spec/sentry/vernier/profiler_spec.rb b/sentry-ruby/spec/sentry/vernier/profiler_spec.rb
@@ -92,12 +92,12 @@
     end
 
     context "when Vernier crashes" do
-      it "logs the error and re-raises" do
+      it "logs the error and does not raise" do
         profiler.set_initial_sample_decision(true)
 
         expect(Vernier).to receive(:start_profile).and_raise("boom")
 
-        expect { profiler.start }.to raise_error("boom")
+        expect { profiler.start }.to_not raise_error("boom")
       end
 
       it "doesn't start if Vernier raises that it already started" do