Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete deprecated configuration method #2073

Closed
wants to merge 1 commit into from
Closed

Delete deprecated configuration method #2073

wants to merge 1 commit into from

Conversation

jeffwidman
Copy link
Contributor

Use Sentry.configuration instead.

This was slated for removal in v5.0.0 but was accidentally left in, so removing as part of v6.0.0.

Related:

Use `Sentry.configuration` instead.

This was slated for removal in `v5.0.0` but was accidentally left in, so removing as part of `v6.0.0`.
@jeffwidman jeffwidman mentioned this pull request Jul 16, 2023
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (7764384) 83.23% compared to head (457ce47) 83.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2073      +/-   ##
==========================================
+ Coverage   83.23%   83.25%   +0.02%     
==========================================
  Files         119      119              
  Lines        5665     5663       -2     
==========================================
  Hits         4715     4715              
+ Misses        950      948       -2     
Impacted Files Coverage Δ
sentry-ruby/lib/sentry/event.rb 72.15% <ø> (+0.54%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sl0thentr0py
Copy link
Member

hey @jeffwidman thanks for this but at some point I'll make a separate PR going through all the deprecations systematically when we do the major. Closing now, sorry!

@jeffwidman
Copy link
Contributor Author

How are you tracking not forgetting them? I opened the PR because it looked like it'd been overlooked on the last major version bump. 😃

@jeffwidman jeffwidman deleted the patch-1 branch July 27, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants