Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Hub from having nil scope and client #2402

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prevent Hub from having nil scope and client #2402

wants to merge 2 commits into from

Commits on Sep 15, 2024

  1. Prevent Hub from having nil scope and client 

    `Hub#pop_scope` currently can cause a Hub to have a nil scope and client,
which would highly likely lead of errors. For example, `Hub#configuration`
would simply cause `NoMethodError`.

This commit prevents that from ever happening by making sure that `Hub#pop_scope`
would at least leave a brand new scope and the old client on the stack.
    @st0012
    st0012 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    34fe19c View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @st0012
    st0012 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    33c73f0 View commit details
    Browse the repository at this point in the history