Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update backtrace dependency and add gimli-symbolize feature flag #189

Closed
wants to merge 1 commit into from

Conversation

qdequele
Copy link

@qdequele qdequele commented Apr 3, 2020

I have updated the backtrace dependency and add gimli-symbolize feature flag.
This feature flag seems to fix the issue #188.
I found how to fix it in the issue rust-lang/backtrace-rs#150.

@qdequele
Copy link
Author

Friendly reminder ;) don't hesitate to tell me if I must modify something.

@Swatinem
Copy link
Member

@jan-auer had some concerns regarding the gimli-symbolize feature, care to explain?

@jan-auer
Copy link
Member

I'm afraid that gimli might not yet be fully ready for replacing backtrace, so I'd just wait for rust-lang/backtrace-rs#189 to play out. Apart from that, it still adds quite some weight, so I'm not sure if I'd go with this by default.

We're in the process of splitting sentry up into multiple smaller crates. One of those might be backtrace support, and I think it may be a great idea to expose that as a feature. Alternatively, one can always include backtrace = { features = "gimli-symbolize", ... } in their Cargo.toml.

@Swatinem
Copy link
Member

Alternatively, one can always include backtrace = { features = "gimli-symbolize", ... } in their Cargo.toml.

I will close this for now, as you can just enforce this feature on all other copies of that library.

@Swatinem Swatinem closed this May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants