actually make error_type = error ... make the error type be error

src/sentry/testutils/factories.py

@@ -965,6 +965,9 @@ def store_event(
         normalized_data = manager.get_data()
         event = None
 
+        if event_type == EventType.ERROR and normalized_data.get("type") == "default":
+            normalized_data["type"] = "error"
+
         # When fingerprint is present on transaction, inject performance problems
         if (
             normalized_data.get("type") == "transaction"

tests/sentry/incidents/endpoints/test_organization_alert_rule_anomalies.py

@@ -75,7 +75,6 @@ def test_simple(self, mock_seer_request, mock_seer_store_request):
             seasonality=AlertRuleSeasonality.AUTO,
             detection_type=AlertRuleDetectionType.DYNAMIC,
         )
-
         self.login_as(self.user)
 
         seer_return_value = {

tests/sentry/seer/anomaly_detection/test_store_data.py

@@ -8,7 +8,7 @@
 from sentry.seer.anomaly_detection.utils import fetch_historical_data, format_historical_data
 from sentry.snuba import errors, metrics_performance
 from sentry.snuba.dataset import Dataset
-from sentry.snuba.models import SnubaQuery, SnubaQueryEventType
+from sentry.snuba.models import SnubaQuery
 from sentry.testutils.cases import BaseMetricsTestCase, PerformanceIssueTestCase
 from sentry.testutils.factories import EventType
 from sentry.testutils.helpers.datetime import iso_format
@@ -88,11 +88,6 @@ def test_anomaly_detection_format_historical_data_two(self):
     def test_anomaly_detection_fetch_historical_data(self):
         alert_rule = self.create_alert_rule(organization=self.organization, projects=[self.project])
         snuba_query = SnubaQuery.objects.get(id=alert_rule.snuba_query_id)
-        # CEO: despite passing event_type to store_event, the event type is default
-        # so we'll just update the type it's looking for to default
-        snuba_query_event_type = SnubaQueryEventType.objects.get(snuba_query=snuba_query)
-        snuba_query_event_type.type = SnubaQueryEventType.EventType.DEFAULT.value
-        snuba_query_event_type.save()
 
         with self.options({"issues.group_attributes.send_kafka": True}):
             self.store_event(
@@ -126,12 +121,7 @@ def test_anomaly_detection_fetch_historical_data_is_unresolved_query(self):
         alert_rule = self.create_alert_rule(organization=self.organization, projects=[self.project])
         snuba_query = SnubaQuery.objects.get(id=alert_rule.snuba_query_id)
         snuba_query.query = "is:unresolved"
-        # CEO: despite passing event_type to store_event, the event type is default
-        # so we'll just update the type it's looking for to default
-        snuba_query_event_type = SnubaQueryEventType.objects.get(snuba_query=snuba_query)
-        snuba_query_event_type.type = SnubaQueryEventType.EventType.DEFAULT.value
         snuba_query.save()
-        snuba_query_event_type.save()
 
         with self.options({"issues.group_attributes.send_kafka": True}):
             self.store_event(