♿️ Add title to context icons

getsentry · Jun 4, 2024 · 2b965d5 · 2b965d5
1 parent 21651cd
commit 2b965d5
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/static/app/components/events/contexts/contextIcon.tsx b/static/app/components/events/contexts/contextIcon.tsx
@@ -139,10 +139,16 @@ function getLogoImage(name: string) {
 type Props = {
   name: string;
   hideUnknown?: boolean;
+  includeTitle?: boolean;
   size?: IconSize;
 };
 
-function ContextIcon({name, size: providedSize = 'xl', hideUnknown = false}: Props) {
+function ContextIcon({
+  name,
+  size: providedSize = 'xl',
+  hideUnknown = false,
+  includeTitle = false,
+}: Props) {
   const theme = useTheme();
   const size = theme.iconSizes[providedSize];
 
@@ -155,7 +161,15 @@ function ContextIcon({name, size: providedSize = 'xl', hideUnknown = false}: Pro
     return null;
   }
 
-  return <img height={size} width={size} css={extraCass} src={imageName} />;
+  return (
+    <img
+      height={size}
+      width={size}
+      css={extraCass}
+      src={imageName}
+      title={includeTitle ? name : undefined}
+    />
+  );
 }
 
 export default ContextIcon;
diff --git a/static/app/components/events/contexts/platform/index.tsx b/static/app/components/events/contexts/platform/index.tsx
@@ -69,6 +69,7 @@ export function getPlatformContextIcon({
       format="sm"
       platform={platformIconName}
       data-test-id={`${platform}-context-icon`}
+      title={platformIconName}
     />
   );
 }
diff --git a/static/app/components/events/contexts/utils.tsx b/static/app/components/events/contexts/utils.tsx
@@ -404,7 +404,7 @@ export function getContextIcon({
   if (iconName.length === 0) {
     return null;
   }
-  return <ContextIcon name={iconName} size="sm" hideUnknown />;
+  return <ContextIcon name={iconName} size="sm" hideUnknown includeTitle />;
 }
 
 export function getFormattedContextData({