Skip to content

Commit

Permalink
chore(similarity): Increase seer delay and add to log (#77474)
Browse files Browse the repository at this point in the history
Increase seer delay between retries
Add worker number to seer failure extra
  • Loading branch information
jangjodi committed Sep 13, 2024
1 parent f808937 commit 9ee78fe
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ def backfill_seer_grouping_records_for_project(
"reason": seer_response.get("reason"),
"current_project_id": current_project_id,
"last_processed_project_index": last_processed_project_index,
"worker_number": worker_number,
},
)
sentry_sdk.capture_exception(Exception("Seer failed during backfill"))
Expand Down
4 changes: 2 additions & 2 deletions src/sentry/tasks/embeddings_grouping/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -411,8 +411,8 @@ def _make_seer_call(
seer_response = _retry_operation(
post_bulk_grouping_records,
create_grouping_records_request,
retries=5,
delay=4,
retries=15,
delay=10,
exceptions=Exception,
)

Expand Down
2 changes: 2 additions & 0 deletions tests/sentry/tasks/test_backfill_seer_grouping_records.py
Original file line number Diff line number Diff line change
Expand Up @@ -1862,6 +1862,7 @@ def test_backfill_seer_grouping_records_gateway_timeout(self, mock_seer_request,
"reason": "Gateway Timeout",
"current_project_id": self.project.id,
"last_processed_project_index": 0,
"worker_number": None,
},
),
call(
Expand Down Expand Up @@ -1915,6 +1916,7 @@ def test_backfill_seer_grouping_records_internal_error(self, mock_seer_request,
"reason": "Internal Error",
"current_project_id": self.project.id,
"last_processed_project_index": 0,
"worker_number": None,
},
),
]
Expand Down

0 comments on commit 9ee78fe

Please sign in to comment.